Skip to content

Comments

Integrate with turbo:load#114

Open
seanpdoyle wants to merge 1 commit intofishbrain:masterfrom
Healthworx-CareFirst:support-turbo-upstream
Open

Integrate with turbo:load#114
seanpdoyle wants to merge 1 commit intofishbrain:masterfrom
Healthworx-CareFirst:support-turbo-upstream

Conversation

@seanpdoyle
Copy link

Administrate 1.0.0 is poised to integrate with Turbo and Stimulus. That means that plugins that utilize client-side JavaScript cannot depend on DOMContentLoaded events in the same way as pre-1.0.0.

First, check for window.Turbo. If that exists, install the listener for turbo:load events.

If not, fall back to using jQuery to attach DOMContentLoaded events.

Administrate `1.0.0` is poised to integrate with Turbo and Stimulus.
That means that plugins that utilize client-side JavaScript cannot
depend on `DOMContentLoaded` events in the same way as pre-1.0.0.

First, check for `window.Turbo`. If that exists, install the listener
for [`turbo:load`][] events.

If not, fall back to using `jQuery` to attach [`DOMContentLoaded`][]
events.

[`turbo:load`]: https://turbo.hotwired.dev/reference/events#turbo%3Aload
[`DOMContentLoaded`]: https://developer.mozilla.org/en-US/docs/Web/API/Document/DOMContentLoaded_event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant