Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Update ad history#39

Merged
fivetran-reneeli merged 15 commits intomainfrom
update_ad_history
Mar 13, 2025
Merged

Update ad history#39
fivetran-reneeli merged 15 commits intomainfrom
update_ad_history

Conversation

@fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Mar 10, 2025

PR Overview

This PR will address the following Issue/Feature: #37

Submission Checklist

Submitter:

  • Alignment meeting with the reviewer
  • Provide validation details:
    • Validation Steps: See internal ticket

    • [] Testing Instructions: Clear steps for running/testing (e.g., scripts, sample data)

See internal ticket

  • [] Focus Areas: na

Reviewer:

  • [] Confirm submission requirements are met

Changelog

  • [] Draft after PR approval

Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good! some doc comments

Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-reneeli fivetran-reneeli merged commit 3b46401 into main Mar 13, 2025
8 checks passed
@fivetran-reneeli fivetran-reneeli deleted the update_ad_history branch March 13, 2025 21:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants