update/order-source-sunset #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
requested changes
Sep 9, 2025
Collaborator
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
@fivetran-catfritz thanks for these updates! I have a few change requests before approval. Let me know if you have any questions.
CHANGELOG.md
Outdated
|
|
||
| ## Schema/Data Changes | ||
|
|
||
| **__ total changes • 0 possible breaking changes** |
Collaborator
There was a problem hiding this comment.
It looks like this needs to be updated.
CHANGELOG.md
Outdated
| | **Data Model/Column** | **Change type** | **Old** | **New** | **Notes** | | ||
| | --------------------- | --------------- | ------- |-------- | --------- | | ||
| | `ORDER` | Source removed | | | Sunset in favor of `ORDERS`, which is now standard across all connections. | | ||
| | [`stg_recharge__discount`](https://fivetran.github.io/dbt_recharge/#!/model/model.zendesk.stg_recharge__discount) | Column removed | `applies_to_id` | | Removed due to inconsistent data types (JSON vs. string) in the source. It can be re-enabled via the `recharge__discount_passthrough_columns` variable. See the [Passing Through Additional Columns](https://github.com/fivetran/dbt_recharge/blob/main/README.md#passing-through-additional-columns) section in the README for usage details. | |
Collaborator
There was a problem hiding this comment.
Small adjustment to highlight the variable is new.
Suggested change
| | [`stg_recharge__discount`](https://fivetran.github.io/dbt_recharge/#!/model/model.zendesk.stg_recharge__discount) | Column removed | `applies_to_id` | | Removed due to inconsistent data types (JSON vs. string) in the source. It can be re-enabled via the `recharge__discount_passthrough_columns` variable. See the [Passing Through Additional Columns](https://github.com/fivetran/dbt_recharge/blob/main/README.md#passing-through-additional-columns) section in the README for usage details. | | |
| | [`stg_recharge__discount`](https://fivetran.github.io/dbt_recharge/#!/model/model.zendesk.stg_recharge__discount) | Column removed | `applies_to_id` | | Removed due to inconsistent data types (JSON vs. string) in the source. It can be re-enabled via the newly added `recharge__discount_passthrough_columns` variable. See the [Passing Through Additional Columns](https://github.com/fivetran/dbt_recharge/blob/main/README.md#passing-through-additional-columns) section in the README for usage details. | |
Comment on lines
-48
to
-49
| - name: is_deleted | ||
| description: This column has been deprecated as of July 2025 in favor of the `_fivetran_deleted` column. Boolean indicating if the order (record) is deleted. |
Collaborator
There was a problem hiding this comment.
This field removal needs to also be documented in the CHANGELOG to highlight the field was removed from the end model as well.
Contributor
Author
There was a problem hiding this comment.
Thank you updated.
Collaborator
There was a problem hiding this comment.
There's a section in the README titled "Leveraging orders vs order source" which needs to be updated/removed following this update.
…ran/dbt_recharge into update/order-source-sunset merge
Contributor
Author
fivetran-catfritz
left a comment
fivetran-catfritz
left a comment
There was a problem hiding this comment.
Thank you @fivetran-joemarkiewicz
Comment on lines
-48
to
-49
| - name: is_deleted | ||
| description: This column has been deprecated as of July 2025 in favor of the `_fivetran_deleted` column. Boolean indicating if the order (record) is deleted. |
Contributor
Author
There was a problem hiding this comment.
Thank you updated.
CHANGELOG.md
Outdated
|
|
||
| ## Schema/Data Changes | ||
|
|
||
| **__ total changes • 0 possible breaking changes** |
CHANGELOG.md
Outdated
| | **Data Model/Column** | **Change type** | **Old** | **New** | **Notes** | | ||
| | --------------------- | --------------- | ------- |-------- | --------- | | ||
| | `ORDER` | Source removed | | | Sunset in favor of `ORDERS`, which is now standard across all connections. | | ||
| | [`stg_recharge__discount`](https://fivetran.github.io/dbt_recharge/#!/model/model.zendesk.stg_recharge__discount) | Column removed | `applies_to_id` | | Removed due to inconsistent data types (JSON vs. string) in the source. It can be re-enabled via the `recharge__discount_passthrough_columns` variable. See the [Passing Through Additional Columns](https://github.com/fivetran/dbt_recharge/blob/main/README.md#passing-through-additional-columns) section in the README for usage details. | |
This was referenced Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
_is_deletedcolumn #37ORDERsource in favor ofORDERS. #36Summary of changes:
Submission Checklist
Changelog