feature/union-data #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
requested review from
fivetran-joemarkiewicz
and removed request for
fivetran-avinash
fivetran-joemarkiewicz
requested changes
Nov 7, 2025
Collaborator
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
@fivetran-savage great work on this PR! A few change requests before approval
integration_tests/tests/consistency/consistency_customer_details.sql
Outdated
Show resolved
Hide resolved
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
fivetran-joemarkiewicz
requested changes
Nov 10, 2025
Collaborator
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
@fivetran-savage thanks for making the suggested changes. I have a few more comments/suggestions before approval. Additionally, I noticed after the most recent round of updates it looks like integration tests are failing. Please look into those failures and make any necessary fixes. Thanks!
integration_tests/tests/consistency/consistency_customer_details.sql
Outdated
Show resolved
Hide resolved
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
…ls.sql Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Refactor date calculation logic to use a query for min and max dates.
…an/dbt_recharge into fivetran-catfritz-patch-1 merge
Added a comment to clarify the date calculation logic.
Added comment for year range creation logic.
Ensure first_date and last_date are strings.
Fivetran catfritz patch 1
fivetran-savage
added
docs:ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist -- IN JIRA
Confirmed that stuff works with the
grouptable on Snowflake by creating agroupand running this branch on that + the rest of the seed dataChangelog