Merged
Conversation
- Use packing args to construct tuple from input
When encountering a message with the single object marker, return the value as-is without wrapping it into a tuple container. This matches the Pybricks behaviour, and partically reverts changes made in a38028c. However, the virtual hub implementation still wraps single values into a single object tuple when returning from observer(). This is due to the type signature on the method of the BLE Hub API, which does require a tuple to be returned. This is likely a bug/inaccuracy of the API types, as the Pybricks firmware itself does not adhere to the type annotation and returns either a single value, or a tuple.
fkleon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
py.typedmarker.pybricksfrom3.5.xto3.6.x.pytest-asyncioto1.0.0.mypyfrom1.15to1.16.