Fix serialization of strings starting with YAML indicator characters#508
Open
rioki wants to merge 8 commits intofktn-k:developfrom
Open
Fix serialization of strings starting with YAML indicator characters#508rioki wants to merge 8 commits intofktn-k:developfrom
rioki wants to merge 8 commits intofktn-k:developfrom
Conversation
Author
|
Not sure why the CI tripped... it failed on git checkout... If I can do anything to help on my end. |
Rolled out test and double checked coverage. Removed bogus empty string test. Rerun amalgamation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects a round-trip issue where certain string values were emitted as plain scalars even though YAML interprets them as structural tokens. For example, a value like
"***"was serialized as:which YAML parses as an alias, causing deserialization to fail.
The serializer now performs a conservative scan of escaped string contents and quotes strings that begin with, or contain, YAML indicator characters that could change parsing semantics (e.g.
*,&,!,#,[/],{/}, etc.). This preserves the intended string type without modifying the parser orscalar_scanner.All existing tests pass, and the added round-trip test covering this case succeeds.
Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdefs or other means.