[Operator Development] Implement acosh operator with tests and benchmarks#1527
Open
minalkharat-cmd wants to merge 3 commits intoflagos-ai:masterfrom
Open
[Operator Development] Implement acosh operator with tests and benchmarks#1527minalkharat-cmd wants to merge 3 commits intoflagos-ai:masterfrom
minalkharat-cmd wants to merge 3 commits intoflagos-ai:masterfrom
Conversation
- Add missing in-place version acos_() function - Improve documentation with detailed docstrings - Add usage examples in docstrings - Maintain compatibility with existing acos() function Part of completing issue flagos-ai#883 Signed-off-by: minalkharat-cmd <minalkharat@gmail.com>
minalkharat-cmd
requested review from
0x45f,
huangyiqun,
kiddyjinjin and
zhangpeiyang1
as code owners
|
|
Contributor
|
@minalkharat-cmd Please sign the CLA in order for your PR to be reviewed. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the acosh (inverse hyperbolic cosine) operator from issue #884.
Changes
pointwise_dynamicimplementationTesting
All functionality implemented with proper domain handling (x >= 1). Tests include
equal_nan=Truefor out-of-domain value handling.Closes
#884