fix: Object layer parsing for JSON format#88
Merged
spydon merged 4 commits intoflame-engine:mainfrom Jun 19, 2025
Merged
Conversation
… was null and didn't get parsed at all
- When loading in JSON from object layers didn't get parsed and where empty - Default values added for ellipse and point properties (as they might not be present in JSON)
spydon
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When loading and parsing JSON Format,
objectGrouplayers wheren't parsed correctly, which resulted in empty entry.The main problem was that in JSON Format it is called "objects" instead of "object" like in XML. Here is a snippet of a JSON file exported with Tiled 1.8.2:
Breaking Change