[1.x] fix: remove redefinition of github token#4218
Merged
imorland merged 1 commit intoflarum:1.xfrom May 28, 2025
Merged
Conversation
Fixes a regression introduced in flarum#4078 in relation to composer auth. It appears as if explicitly defining it in the job interferes with how actions such as shivammathur/setup-php@v2 authenticate with composer.
imorland
approved these changes
May 28, 2025
Member
imorland
left a comment
There was a problem hiding this comment.
Thanks for the swift fix @DavideIadeluca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Fixes a regression introduced in #4078 in relation to composer auth not working anymore.
It appears as if explicitly defining it in the job interferes with how actions such as shivammathur/setup-php@v2 authenticate with composer.
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot
Necessity
Confirmed
composer test).Required changes: