Skip to content

Added a License file#39

Open
Riverfount wants to merge 2 commits intoflask-extensions:masterfrom
Riverfount:37
Open

Added a License file#39
Riverfount wants to merge 2 commits intoflask-extensions:masterfrom
Riverfount:37

Conversation

@Riverfount
Copy link
Member

@Riverfount Riverfount commented Apr 18, 2020

Close #37

@jairomr
Copy link
Contributor

jairomr commented Apr 18, 2020

Seria bom adicionar a licença nos arquivo pyproject.toml

@schonfinkel
Copy link
Contributor

schonfinkel commented Apr 19, 2020

@Riverfount Se for usar GPL como o @jairomr mencionou seria legal adicionar essa informação também no pyproject.toml. Consultando as docs acho que ficaria algo assim:

[tool.poetry]
name = ...
version = ...
description = ...
authors = ...
license = "GPL-3.0-only"

@Riverfount
Copy link
Member Author

Riverfount commented Apr 19, 2020

e for usar GPL como o @jairomr mencionou seria legal adicionar

Feito. Só fazerem a revisão e mergear o PR!

@schonfinkel
Copy link
Contributor

schonfinkel commented Apr 19, 2020 •
edited
Loading

Foi sugerida MIT também no issue, melhor ver o que os reviewers acham da ideia de usar GPL. Se eles não quiserem eu até entendo, as vezes quem olha o projeto por fora acaba não usando só por medo da licença.

marcuxyz
marcuxyz approved these changes Apr 19, 2020
View reviewed changes
Copy link
Member

@marcuxyz marcuxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like good for me.

schonfinkel
schonfinkel reviewed Apr 19, 2020
View reviewed changes
rochacbruno
rochacbruno reviewed Apr 23, 2020
View reviewed changes
Copy link
Member

@rochacbruno rochacbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precisamos discutir melhor isso, se seria melhor GPL, MIT ou simplesmente alguma outra licença super permissiva.

@rochacbruno rochacbruno added help wanted Extra attention is needed question Further information is requested DO NOT MERGE labels Apr 23, 2020
@robsonsilv4
Copy link

robsonsilv4 commented Apr 25, 2020

Também a BSD como opção.
Mas como o @rochacbruno disse, acho melhor discutir mais um pouco sobre isso.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rochacbruno rochacbruno rochacbruno left review comments

@marcuxyz marcuxyz marcuxyz approved these changes

+1 more reviewer

@schonfinkel schonfinkel schonfinkel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DO NOT MERGE help wanted Extra attention is needed question Further information is requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add license file to the project

6 participants

@Riverfount @jairomr @schonfinkel @robsonsilv4 @rochacbruno @marcuxyz