fix: 2022 - no fling beyond the antimeridian if constrained#2168
Draft
monsieurtanuki wants to merge 5 commits intofleaflet:masterfrom
Draft
fix: 2022 - no fling beyond the antimeridian if constrained#2168monsieurtanuki wants to merge 5 commits intofleaflet:masterfrom
monsieurtanuki wants to merge 5 commits intofleaflet:masterfrom
Conversation
New file: * `antimeridian.dart`: Testing if we can fling beyond the world. We can't, due to the constraint. Impacted files: * `camera_constraint.dart` * `main.dart`: added new `AntimeridianPage` page. * `map_interactive_viewer.dart` * `menu_drawer.dart`
Member
|
Hey @monsieurtanuki, I can't seem to actually fling at all now? (Testing on Windows with a mouse) |
Contributor
Author
|
@JaffaKetchup I'll double-check that tomorrow. |
Contributor
Author
@JaffaKetchup Quickly said: you're right :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix in 2 parts:
Files
New file:
antimeridian.dart: Testing if we can fling beyond the world. We can't, due to the constraint.Impacted files:
camera_constraint.dart: special case when the constraint is the worldmain.dart: added newAntimeridianPagepage.map_interactive_viewer.dart: stop fling when themoveRawfailsmenu_drawer.dart: added newAntimeridianPagepage.