Skip to content

Conversation

@iansltx
Copy link
Member

@iansltx iansltx commented Jun 3, 2025

More work to fix #29720.

@fleet-release fleet-release added the ~ceo PR requesting review from the CEO or issue related to EA tasks label Jun 3, 2025
@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.23%. Comparing base (c8bd067) to head (ec41a25).
Report is 123 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #29742   +/-   ##
=======================================
  Coverage   64.23%   64.23%           
=======================================
  Files        1852     1852           
  Lines      180476   180501   +25     
  Branches     5248     5255    +7     
=======================================
+ Hits       115926   115944   +18     
- Misses      55436    55443    +7     
  Partials     9114     9114           
Flag Coverage Δ
frontend 53.93% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iansltx iansltx force-pushed the 29720-click-here-docs-ee-frontend branch from 9539924 to 788d5a7 Compare June 3, 2025 23:24
@iansltx iansltx requested review from a team and Sampfluger88 as code owners June 3, 2025 23:24
@iansltx iansltx changed the base branch from 29720-click-here to main June 3, 2025 23:25
@iansltx
Copy link
Member Author

iansltx commented Jun 3, 2025

Rebased this to be independent of #29731. Will add a 3rd PR for performing the same fixes on articles.

lukeheath
lukeheath previously approved these changes Jun 4, 2025
Sampfluger88
Sampfluger88 previously approved these changes Jun 5, 2025
@iansltx
Copy link
Member Author

iansltx commented Jun 6, 2025

@rachaelshaw @mostlikelee @georgekarrv I think I need approvals from all three of y'all to merge this.

@noahtalerman
Copy link
Member

@rachaelshaw changes look good to me! Please feel free to give your CODEOWNER approval.

(FYI I'm reviewing for Rachael to give Rachael some time back for drafting.)

@iansltx
Copy link
Member Author

iansltx commented Jun 11, 2025

@lukeheath Need your +1 once more here due to changes made since your review. Looks like we're good to go at that point. Thx!

@noahtalerman noahtalerman requested a review from lukeheath June 12, 2025 13:50
Copy link
Member

@lukeheath lukeheath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@iansltx iansltx merged commit 6f772a4 into main Jun 13, 2025
16 checks passed
@iansltx iansltx deleted the 29720-click-here-docs-ee-frontend branch June 13, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

~ceo PR requesting review from the CEO or issue related to EA tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Links on website have "here" and "click here" anchors

10 participants