#23899 API design (IdP department/group labels) #29992

rachaelshaw · 2025-06-13T15:31:23Z

rachaelshaw · 2025-06-13T15:32:25Z

docs/Configuration/yaml-files.md

+  - name: Engineering department
+    description: "Hosts with end users in engineering"
+    type: Host vitals
+    criteria:
+      vital: end_user_idp_department
+      value: Engineering


Dev note

TODO

FUTURE

This is how more complex criteria could look in the future:

name: Engineering department or IT admins who are named Ricky description: Hosts with end users in engineering or who are IT admins named Ricky type: Host vitals criteria: or: - and: - vital: end_user_idp_groups - value: IT admins - vital: end_user_first_name - value: Ricky - vital: end_user_idp_department value: Engineering

docs/Configuration/yaml-files.md

rachaelshaw · 2025-06-13T15:47:10Z

docs/Configuration/yaml-files.md

+  - name: Engineering department
+    description: "Hosts with end users in engineering"
+    type: host_vitals
+    criteria:
+      vital: end_user_idp_department
+      value: Engineering


Dev note

TODO

FUTURE

This is how more complex criteria could look in the future:

name: Engineering department or IT admins who are named Ricky description: Hosts with end users in engineering or who are IT admins named Ricky type: Host vitals criteria: or: - and: - vital: end_user_idp_groups value: IT admins - vital: end_user_first_name value: Ricky - vital: end_user_idp_department value: Engineering

Fixes #26519

Fixes CVE-2025-22874 reported by https://github.com/fleetdm/fleet/actions/runs/15601368321/job/43941793647. (IMO not a critical CVE, so it doesn't need to be cherry-picked into v4.69.0.) Added automation to make this easier next time.

…29975) Fixes #29973 Tests are failing due to infra issues with https://proxy.golang.org # Checklist for submitter - [x] Manual QA for all new/changed functionality

Closes: #30000 Changes: - Updated the version of node used by the website to `^20.18`

For #29323 , contributor docs changes only (follow-up to #29555).

More work to fix #29720. --------- Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>

…30003) Changes: - Updated the return value of the create-historical-event helper.

Fixes #26519

- Added a package that installs Fleet's Keynote theme and related fonts to self-service

related to: #30005 Changes: - Compressed and resized large gifs in the "Preventing Mistakes with GitOps" article - Removed unused website assets

…ing that hash exists in Fleet (#29866) Updated documentation to be more clear on behavior if hash is provided for software package in YAML.

Fixes #26519

This PR adds VEX statement files for three vulverabilities: ``` ┌─────────┬────────────────┬──────────┬──────────┬─────────────────────────┬───────────────┬──────────────────────────────────────────────────────────────┐ │ Library │ Vulnerability │ Severity │ Status │ Installed Version │ Fixed Version │ Title │ ├─────────┼────────────────┼──────────┼──────────┼─────────────────────────┼───────────────┼──────────────────────────────────────────────────────────────┤ │ libxml2 │ CVE-2025-49794 │ CRITICAL │ affected │ 2.9.14+dfsg-1.3~deb12u1 │ │ libxml: Heap use after free (UAF) leads to Denial of service │ │ │ │ │ │ │ │ (DoS)... │ │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2025-49794 │ │ ├────────────────┤ │ │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ │ CVE-2025-49795 │ │ │ │ │ libxml: Null pointer dereference leads to Denial of service │ │ │ │ │ │ │ │ (DoS) │ │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2025-49795 │ │ ├────────────────┤ │ │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ │ CVE-2025-49796 │ │ │ │ │ libxml: Type confusion leads to Denial of service (DoS) │ │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2025-49796 │ └─────────┴────────────────┴──────────┴──────────┴─────────────────────────┴───────────────┴──────────────────────────────────────────────────────────────┘ ``` the vulnerabilities in libxml2 do not affect fleetctl, since the attack vector is DoS and fleetctl is not a server tool. Additionally the libxml2 package isn't used by fleetctl directly, but by the tools it uses for code signing, which don't parse untrusted XML.

Related to: - #29789 --------- Co-authored-by: Rachael Shaw <r@rachael.wtf>

codecov · 2025-06-13T22:58:04Z

Codecov Report

Attention: Patch coverage is 38.46154% with 24 lines in your changes missing coverage. Please review.

Project coverage is 64.10%. Comparing base (f238292) to head (55b21fb).
Report is 28 commits behind head on docs-v4.71.0.

Files with missing lines	Patch %	Lines
cmd/osquery-perf/agent.go	0.00%	24 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           docs-v4.71.0   #29992      +/-   ##
================================================
+ Coverage         60.45%   64.10%   +3.65%     
================================================
  Files              1865     1865              
  Lines            182331   182345      +14     
  Branches           5255     5332      +77     
================================================
+ Hits             110232   116897    +6665     
+ Misses            63496    56246    -7250     
- Partials           8603     9202     +599

Flag	Coverage Δ
backend	`65.04% <38.46%> (+4.02%)`	⬆️
frontend	`53.89% <ø> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rachaelshaw · 2025-06-13T22:58:07Z

Merged in main, now the diff is unwieldy. Making a new PR 🤦‍♀️

Update yaml-files.md

8b2cabb

fleet-release approved these changes Jun 13, 2025

View reviewed changes

rachaelshaw temporarily deployed to Docker Hub June 13, 2025 15:31 — with GitHub Actions Inactive

rachaelshaw had a problem deploying to Docker Hub June 13, 2025 15:31 — with GitHub Actions Failure

rachaelshaw commented Jun 13, 2025

View reviewed changes

rachaelshaw mentioned this pull request Jun 13, 2025

Add labels based on end user's IdP information #23899

Closed

15 tasks

RachelElysia and others added 2 commits June 13, 2025 11:36

Uploading new installer to FMA turns FMA to custom package (#29959)

b763b68

UI: Consistent password field styling (#29984)

69cd060

rachaelshaw commented Jun 13, 2025

View reviewed changes

docs/Configuration/yaml-files.md Outdated Show resolved Hide resolved

Update docs/Configuration/yaml-files.md

3406a61

fleet-release approved these changes Jun 13, 2025

View reviewed changes

rachaelshaw had a problem deploying to Docker Hub June 13, 2025 15:44 — with GitHub Actions Error

rachaelshaw commented Jun 13, 2025

View reviewed changes

docs/Configuration/yaml-files.md Outdated Show resolved Hide resolved

Update docs/Configuration/yaml-files.md

397b828

fleet-release approved these changes Jun 13, 2025

View reviewed changes

rachaelshaw had a problem deploying to Docker Hub June 13, 2025 15:45 — with GitHub Actions Failure

rachaelshaw temporarily deployed to Docker Hub June 13, 2025 15:45 — with GitHub Actions Inactive

rachaelshaw commented Jun 13, 2025

View reviewed changes

getvictor and others added 11 commits June 13, 2025 12:27

Updating Android changelog. (#29995)

6a1c790

Fixes #26519

Update 26519-android changelog (#29996)

9ba6e74

Fix broken link for IDP documentation (#29998)

06a9b1f

Fix malformed engineering handbook links (#29816)

af1c2e8

Fix osquery_perf so it doesn't miss DeclarativeManagement commands. (#…

e360e7e

…29975) Fixes #29973 Tests are failing due to infra issues with https://proxy.golang.org # Checklist for submitter - [x] Manual QA for all new/changed functionality

Move Victor to orchestration. (#29918)

bfb259f

Website: bump node version (#30002)

09a3e98

Closes: #30000 Changes: - Updated the version of node used by the website to `^20.18`

Regenerate host vitals doc for osquery query change (#29915)

4dfe953

For #29323 , contributor docs changes only (follow-up to #29555).

Bump brace-expansion from 1.1.11 to 1.1.12 (#29953)

1139e07

Clean up "here" link anchors for docs, ee, and frontend dirs (#29742)

6f772a4

More work to fix #29720. --------- Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>

eashaw and others added 10 commits June 13, 2025 15:15

Website: Update returned value from create-historical-event helper. (#…

de8bac0

…30003) Changes: - Updated the return value of the create-historical-event helper.

Updating Android contributor docs. (#29880)

8d4bf5b

Fixes #26519

Add Fleet's Keynote them to self-service (#30008)

acf8274

- Added a package that installs Fleet's Keynote theme and related fonts to self-service

Website: reduce website slug size (#30010)

9d08753

related to: #30005 Changes: - Compressed and resized large gifs in the "Preventing Mistakes with GitOps" article - Removed unused website assets

Clarify behavior when hash is provided in GitOps but no package match…

ea7bad3

…ing that hash exists in Fleet (#29866) Updated documentation to be more clear on behavior if hash is provided for software package in YAML.

Documented Android fleetdm.com proxy endpoints. (#29901)

5a8f338

Fixes #26519

Labels section included twice in YAML files docs (#29859)

af2bdf0

Related to: - #29789 --------- Co-authored-by: Rachael Shaw <r@rachael.wtf>

Docs: Add spacing in labels note (#30014)

0f3c9fd

Merge branch 'main' into 23899-api-design

55b21fb

rachaelshaw temporarily deployed to Docker Hub June 13, 2025 22:55 — with GitHub Actions Inactive

rachaelshaw had a problem deploying to Docker Hub June 13, 2025 22:55 — with GitHub Actions Error

rachaelshaw closed this Jun 13, 2025

rachaelshaw temporarily deployed to Docker Hub June 13, 2025 22:59 — with GitHub Actions Inactive

rachaelshaw had a problem deploying to Docker Hub June 13, 2025 22:59 — with GitHub Actions Error

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#23899 API design (IdP department/group labels) #29992

#23899 API design (IdP department/group labels) #29992

Uh oh!

rachaelshaw commented Jun 13, 2025

Uh oh!

rachaelshaw Jun 13, 2025

Uh oh!

Uh oh!

Uh oh!

rachaelshaw Jun 13, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jun 13, 2025 •

edited

Loading

Uh oh!

rachaelshaw commented Jun 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

#23899 API design (IdP department/group labels) #29992

#23899 API design (IdP department/group labels) #29992

Uh oh!

Conversation

rachaelshaw commented Jun 13, 2025

Uh oh!

rachaelshaw Jun 13, 2025

Choose a reason for hiding this comment

Dev note

FUTURE

Uh oh!

Uh oh!

Uh oh!

rachaelshaw Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Dev note

FUTURE

Uh oh!

codecov bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rachaelshaw commented Jun 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

rachaelshaw Jun 13, 2025 •

edited

Loading

codecov bot commented Jun 13, 2025 •

edited

Loading