Dogfood tf deprecation fixes #31835
Closed
Dogfood tf deprecation fixes #31835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t apply for dogfood
BCTBB
requested review from
ddribeiro,
edwardsb,
georgekarrv,
ksatter,
lukeheath,
mostlikelee,
rfairburn and
sharon-fdm
as code owners
rfairburn
previously approved these changes
Aug 12, 2025
… data.aws_region.current.region
rfairburn
previously approved these changes
Aug 12, 2025
Contributor
Author
|
The terraform plan dry-run changes are working as expected on the branch. |
… osquery hosts, as the terraform provider was going to force the values to default to DISABLED (default)
For #31571. Steps to reproduce at the end of the description here: #31571. - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. ## Testing - [X] Added/updated automated tests - [X] QA'd all new/changed functionality manually
Created two new rituals: - Updating KPIs - Importing LinkedIn posts to Clay
- Updated text in the UI to be more accurate and friendly
- Adjusting path to troubleshoot adding the EULA via GitOps
- @noahtalerman: I set my hostname to "Noah Talerman's MacBook Pro"
Fixing broken link
fixes: #29222 This is a feature branch that was completed last week, but did not get merged in time. All pr's going in was approved, and reviewed. I will after this is merged, do a cherry pick onto the RC 4.73 branch, and initiate the FR merge process. --------- Co-authored-by: Martin Angers <martin.n.angers@gmail.com> Co-authored-by: Sarah Gillespie <73313222+gillespi314@users.noreply.github.com> Co-authored-by: Gabriel Hernandez <ghernandez345@gmail.com>
….g. uninstalled (#32005) Fixes #29894 and probably #31980. # Checklist for submitter If some of the following don't apply, delete the relevant line. - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) ## Testing - [x] Added/updated automated tests - [x] QA'd all new/changed functionality manually
- @noahtalerman: Remove recurring scripts
I am sorry. --------- Co-authored-by: Mike Thomas <78363703+mike-j-thomas@users.noreply.github.com>
Fixes: #4498 # Checklist for submitter If some of the following don't apply, delete the relevant line. - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. ## Testing - [x] Added/updated automated tests - Added unit test - Changed existing unit tests to accept empty array instead of null - [x] QA'd all new/changed functionality manually - Tested that Fleet UI > host details, returns `software: []` instead of nothing. - Tested that with exclude_software=false, software returns the full array for host. --------- Co-authored-by: Anthony Maxwell <133805840+Illbjorn@users.noreply.github.com>
- Updated configuration profile to support macOS26 More info link - Updated policy logic to account for old versions of Nudge being installed
Automated change from [GitHub action](https://github.com/fleetdm/fleet/actions/workflows/fleetd-tuf.yml). Co-authored-by: lucasmrod <lucasmrod@users.noreply.github.com>
For #29795 Refactored the way we compute the number of failing policies to avoid discrepancies due to either read replica delays or due to async nature of the failing policy computation stored in host issues.
For #32007. Added missing permissions for attestation.
Fixes #30483 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added a new webhook endpoint to track GitHub Projects v2 item status changes and record engineering metrics. * Integrated with Google BigQuery for storing and analyzing issue status transition data. * **Chores** * Introduced a new POST API route for receiving GitHub Projects v2 item events. * Added configuration options for GitHub webhook secrets and Google Cloud service account keys (commented out for future use). * Added a new dependency for Google BigQuery integration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Eric <eashaw@sailsjs.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #31835 +/- ##
==========================================
+ Coverage 63.76% 63.98% +0.21%
==========================================
Files 1963 1986 +23
Lines 192074 194044 +1970
Branches 6278 6496 +218
==========================================
+ Hits 122480 124157 +1677
- Misses 60021 60196 +175
- Partials 9573 9691 +118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
infrastructure/dogfood/terraform/aws-tf-module/docker/main.tf>= 5.0instead of~> 5.0infrastructure/dogfood/terraform/aws-tf-module/main.tfdata.aws_region.current.id->data.aws_region.current.regiondata.aws_region.current.name->data.aws_region.current.region>= 5.0.0instead of~> 5.0.0tf-mod-root-v1.15.2->tf-mod-root-v1.17.0tf-mod-addon-migrations-v2.0.1->tf-mod-addon-migrations-v2.1.0tf-mod-addon-osquery-carve-v1.1.0->tf-mod-addon-osquery-carve-v1.1.1tf-mod-addon-logging-alb-v1.3.0->tf-mod-addon-logging-alb-v1.4.0tf-mod-addon-external-vuln-scans-v2.2.1->tf-mod-addon-external-vuln-scans-v2.3.0infrastructure/dogfood/terraform/aws-tf-module/free.tfdata.aws_region.current.id->data.aws_region.current.regiondata.aws_region.current.name->data.aws_region.current.regiontf-mod-byo-vpc-v1.13.0->tf-mod-byo-vpc-v1.18.3tf-mod-addon-ses-v1.3.0->tf-mod-addon-ses-v1.4.0tf-mod-addon-migrations-v2.0.1->tf-mod-addon-migrations-v2.1.0infrastruture/dogfood/terraform/aws-tf-module/free-ecs-hosts.tfavailability_zone_rebalancingto keep asENABLED(current value) where the latest provider attempts to set toDISABLED(default value)