Conversation
|
@sharon-fdm can you please assign someone for review? |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #39276 +/- ##
==========================================
- Coverage 66.18% 64.36% -1.82%
==========================================
Files 2424 2398 -26
Lines 194210 187411 -6799
Branches 8460 8460
==========================================
- Hits 128541 120635 -7906
- Misses 53983 55866 +1883
+ Partials 11686 10910 -776
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lucasmrod
left a comment
lucasmrod
left a comment
There was a problem hiding this comment.
LGTM. Left a few small comments.
| // Get the container's spec to access mount information | ||
| spec, err := container.Spec(nsCtx) | ||
| if err != nil { | ||
| log.Printf("Failed to get spec for container %s: %v", container.ID(), err) |
There was a problem hiding this comment.
Nit: Will this be noisy? (If so maybe log.Debug().Printf.)
There was a problem hiding this comment.
I don't think it should be noisy (didn't see any logging in my testing), but I am not certain.
Co-authored-by: Lucas Manuel Rodriguez <lucas@fleetdm.com>
| // Get the container's spec to access mount information | ||
| spec, err := container.Spec(nsCtx) | ||
| if err != nil { | ||
| log.Printf("Failed to get spec for container %s: %v", container.ID(), err) |
There was a problem hiding this comment.
@lucasmrod changed this back to %v due to lint issue: https://github.com/fleetdm/fleet/actions/runs/21726354717/job/62669349188?pr=39276
4 participants
Related issue: Resolves #38393
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Testing
fleetd/orbit/Fleet Desktop
runtime.GOOSis used as needed to isolate changes