fix(tidy3d): FXC-5400-misleading-re-run-warning-for-batch-run#3228
Merged
marcorudolphflex merged 1 commit intodevelopfrom Feb 6, 2026
Merged
Conversation
Contributor
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changes
Summary
tidy3d/web/api/container.pyLines 1283-1291 1283 job_path = self._job_data_path(task_id=job.task_id, path_dir=path_dir)
1284
1285 if job_path.exists():
1286 if replace_existing:
! 1287 log.debug(f"File '{job_path}' already exists. Overwriting.")
1288 else:
1289 log.debug(f"File '{job_path}' already exists. Skipping.")
1290 continue |
yaugenst-flex
approved these changes
Feb 4, 2026
tylerflex
approved these changes
Feb 4, 2026
Collaborator
tylerflex
left a comment
There was a problem hiding this comment.
looks good, minor flag on the log level
fa412d8 to
5c67737
Compare
5c67737 to
472a6dc
Compare
472a6dc to
753839d
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace_existingtoBatch.run()and threaded it through cached-download anddownload_on_successpaths so overwrite behavior is controllable from the top-level API.Note
Low Risk
Behavior change is limited to batch file download/overwrite control and logging levels; minimal impact beyond download semantics when users opt into overwriting.
Overview
Makes
Batch.run()expose areplace_existingflag and threads it through both the cached-results path and thedownload_on_successmonitoring path, so callers can control overwrite behavior from the top-level run API.Reduces download log noise by emitting a single info message when existing batch result files will be skipped (instead of warning-level/duplicated output) and downgrading per-file “skipping/overwriting” messages to debug. Updates the changelog entry accordingly.
Written by Cursor Bugbot for commit 753839d. This will update automatically on new commits. Configure here.