Skip to content

fix(tidy3d): FXC-5400-misleading-re-run-warning-for-batch-run#3228

Merged
marcorudolphflex merged 1 commit intodevelopfrom
FXC-5400-misleading-re-run-warning-for-batch-run
Feb 6, 2026
Merged

fix(tidy3d): FXC-5400-misleading-re-run-warning-for-batch-run#3228
marcorudolphflex merged 1 commit intodevelopfrom
FXC-5400-misleading-re-run-warning-for-batch-run

Conversation

@marcorudolphflex
Copy link
Contributor

@marcorudolphflex marcorudolphflex commented Feb 4, 2026

  • Added replace_existing to Batch.run() and threaded it through cached-download and download_on_success paths so overwrite behavior is controllable from the top-level API.
  • Reduced redundant batch download logs:
    • A single warning now reports existing files.
    • Per-file skips are downgraded to debug.

Note

Low Risk
Behavior change is limited to batch file download/overwrite control and logging levels; minimal impact beyond download semantics when users opt into overwriting.

Overview
Makes Batch.run() expose a replace_existing flag and threads it through both the cached-results path and the download_on_success monitoring path, so callers can control overwrite behavior from the top-level run API.

Reduces download log noise by emitting a single info message when existing batch result files will be skipped (instead of warning-level/duplicated output) and downgrading per-file “skipping/overwriting” messages to debug. Updates the changelog entry accordingly.

Written by Cursor Bugbot for commit 753839d. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

  • tidy3d/web/api/container.py (80.0%): Missing lines 1287

Summary

  • Total: 5 lines
  • Missing: 1 line
  • Coverage: 80%

tidy3d/web/api/container.py

Lines 1283-1291

  1283             job_path = self._job_data_path(task_id=job.task_id, path_dir=path_dir)
  1284 
  1285             if job_path.exists():
  1286                 if replace_existing:
! 1287                     log.debug(f"File '{job_path}' already exists. Overwriting.")
  1288                 else:
  1289                     log.debug(f"File '{job_path}' already exists. Skipping.")
  1290                     continue

Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, minor flag on the log level

@marcorudolphflex marcorudolphflex force-pushed the FXC-5400-misleading-re-run-warning-for-batch-run branch from fa412d8 to 5c67737 Compare February 5, 2026 07:43
@marcorudolphflex marcorudolphflex force-pushed the FXC-5400-misleading-re-run-warning-for-batch-run branch from 5c67737 to 472a6dc Compare February 6, 2026 10:13
@marcorudolphflex marcorudolphflex force-pushed the FXC-5400-misleading-re-run-warning-for-batch-run branch from 472a6dc to 753839d Compare February 6, 2026 10:15
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@marcorudolphflex marcorudolphflex added this pull request to the merge queue Feb 6, 2026
Merged via the queue into develop with commit 077cf70 Feb 6, 2026
51 of 55 checks passed
@marcorudolphflex marcorudolphflex deleted the FXC-5400-misleading-re-run-warning-for-batch-run branch February 6, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants