fix: preserve NaN and Infinity values in typed arrays#349
Open
kaigritun wants to merge 1 commit intoflightcontrolhq:mainfrom
Open
fix: preserve NaN and Infinity values in typed arrays#349kaigritun wants to merge 1 commit intoflightcontrolhq:mainfrom
kaigritun wants to merge 1 commit intoflightcontrolhq:mainfrom
Conversation
Fixes flightcontrolhq#292 Previously, NaN and Infinity values in typed arrays like Float64Array were incorrectly serialized as null by JSON.stringify, causing data loss during deserialization (NaN -> null -> 0). This change encodes special float values (NaN, Infinity, -Infinity) as strings within typed arrays during serialization and converts them back during deserialization, consistent with how these values are handled elsewhere in superjson. Added test case covering Float64Array and Float32Array with NaN and Infinity values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #292
Float64Arrayand other typed arrays that containNaNorInfinityvalues were being corrupted during serialization becauseJSON.stringifyconverts these values tonull.Before
After
Changes
typedArrayRuleintransformer.tsto encodeNaN,Infinity, and-Infinityas strings during serializationFloat64ArrayandFloat32Arraywith special float valuesTesting
All existing tests pass. Added a new test case specifically for this fix.