test(common): migrate label_test.go to Ginkgo/Gomega

[devsubid]

What this PR does

Migrates pkg/common/label_test.go from testing.T + testify to Ginkgo v2 + Gomega for BDD-style testing.

Changes

• Add common_suite_test.go for Ginkgo test suite setup
• Convert table-driven tests to DescribeTable/Entry
• Use explicit ginkgo./gomega. prefixes to avoid naming conflict with common.Succeed

Related Issue

Part of #5407

Test Results

All 13 specs pass:

=== RUN   TestCommon
Running Suite: Package Common Suite - C:\MYPROJECT\fluid\pkg\common
===================================================================
Random Seed: 1769859074

Will run 13 of 13 specs
+++++++++++++

Ran 13 of 13 Specs in 0.001 seconds
SUCCESS! -- 13 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestCommon (0.00s)
=== RUN   TestGetDefaultTieredStoreOrder
--- PASS: TestGetDefaultTieredStoreOrder (0.00s)
=== RUN   TestCriticalFusePodEnabled
--- PASS: TestCriticalFusePodEnabled (0.00s)
=== RUN   TestPortCheckEnabled
--- PASS: TestPortCheckEnabled (0.00s)
=== RUN   TestIsFluidNativeScheme
--- PASS: TestIsFluidNativeScheme (0.00s)
=== RUN   TestIsFluidWebScheme
--- PASS: TestIsFluidWebScheme (0.00s)
=== RUN   TestIsFluidRefScheme
--- PASS: TestIsFluidRefScheme (0.00s)
=== RUN   TestHostPIDEnabled
=== RUN   TestHostPIDEnabled/nil,_return_false
=== RUN   TestHostPIDEnabled/not_exist,_return_false
=== RUN   TestHostPIDEnabled/wrong_value,_return_false
=== RUN   TestHostPIDEnabled/exist,_return_true
=== RUN   TestHostPIDEnabled/exist_True,_return_true
--- PASS: TestHostPIDEnabled (0.00s)
    --- PASS: TestHostPIDEnabled/nil,_return_false (0.00s)
    --- PASS: TestHostPIDEnabled/not_exist,_return_false (0.00s)
    --- PASS: TestHostPIDEnabled/wrong_value,_return_false (0.00s)
    --- PASS: TestHostPIDEnabled/exist,_return_true (0.00s)
    --- PASS: TestHostPIDEnabled/exist_True,_return_true (0.00s)
PASS
ok      github.com/fluid-cloudnative/fluid/pkg/common   0.214s

[fluid-e2e-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zwwhdls for approval by writing /assign @zwwhdls in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @devsubid, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the unit tests within pkg/common/label_test.go by transitioning them from the standard Go testing.T package and testify assertions to the Ginkgo v2 and Gomega BDD testing frameworks. This change aims to enhance the clarity, expressiveness, and maintainability of the tests by adopting a more behavior-driven approach, aligning with modern testing practices.

Highlights

• Test Framework Migration: Migrated pkg/common/label_test.go from testing.T and testify to Ginkgo v2 and Gomega for BDD-style testing.
• New Test Suite Setup: Introduced common_suite_test.go to configure the Ginkgo test suite for the common package.
• Test Structure Refinement: Converted existing table-driven tests to Ginkgo's DescribeTable/Entry format for improved readability and structure.
• Naming Convention: Adopted explicit ginkgo. and gomega. prefixes to prevent naming conflicts, particularly with common.Succeed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[fluid-e2e-bot]

Hi @devsubid. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
19.4% Duplication on New Code

See analysis details on SonarQube Cloud

[gemini-code-assist]

Code Review

This pull request successfully migrates the tests in pkg/common/label_test.go from testing.T and testify to Ginkgo v2 and Gomega. The new common_suite_test.go file correctly sets up the Ginkgo test suite. The conversion of individual tests, including table-driven tests using DescribeTable and Entry, is well-executed and maintains the original test logic. The use of explicit ginkgo. and gomega. prefixes avoids potential naming conflicts, as noted in the PR description. Overall, this is a clean and effective migration that improves the test suite's readability and maintainability by adopting a BDD-style framework.