#feat:Native Sidecar Default Mode + Backward Compatibility

[kryptonn36]

Ⅰ. Describe what this PR does

This PR improves the sidecar injection workflow by safely handling native sidecar discovery logic and preventing unexpected failures during runtime initialization and testing.

The injector now correctly aligns with the native sidecar detection mechanism while preserving the original behavior for existing workloads. This helps ensure stable sidecar creation without introducing breaking changes.

Ⅱ. Does this pull request fix one issue?

fixes #5320

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

No new test cases were added.
The existing unit tests already cover the affected logic paths, and all current tests pass after this change, ensuring behavior consistency.

Ⅳ. Describe how to verify it

Run unit tests:

    go test ./...

Verify sidecar injection behavior during runtime creation
Confirm no regressions in existing workloads

Ⅴ. Special notes for reviews

This change is minimal and focused on improving robustness of native sidecar detection logic without modifying existing interfaces or behavior.

[fluid-e2e-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yangyuliufeng for approval by writing /assign @yangyuliufeng in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @kryptonn36, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the sidecar injection mechanism by introducing a dynamic mode that intelligently adapts to the Kubernetes cluster's capabilities. It ensures that the appropriate sidecar injection method (native or legacy) is used based on the Kubernetes version, while also improving the robustness of API discovery and maintaining full backward compatibility for existing deployments.

Highlights

• Dynamic Sidecar Injection Mode: The injector now dynamically determines whether to use native sidecar injection or legacy mode based on the Kubernetes cluster's version, specifically checking for Kubernetes 1.29+.
• Backward Compatibility: The system maintains backward compatibility by defaulting to a dynamic mode when no specific sidecar injection mode is configured, ensuring existing workloads are not disrupted.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[fluid-e2e-bot]

Hi @kryptonn36. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gemini-code-assist]

Code Review

This pull request introduces a mechanism to auto-detect native sidecar support and fall back to legacy mode if needed, which improves robustness. The changes in injector.go and api_discover.go are solid improvements.

My review focuses on the new sidecar.go file. I've left a couple of comments:

1. A high-severity comment to remove a debug print statement.
2. A medium-severity comment to improve error handling by adding logging for swallowed errors, which will enhance observability.

Overall, the changes are good and move the project in the right direction for sidecar injection.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[kryptonn36]

@cheyang can you please review it and tell me if there is any changes required