Open
Conversation
Contributor
Author
|
@demchenkoalex Putin this on draft to get your input, as integrating in my app, especially with a thumbnail raised quite a lot of questions I wanna discuss with you.
final fullSizeimageBytes =
await VideoThumbnail.thumbnailData(
video: videoUrl,
imageFormat: ImageFormat.WEBP,
quality: 1,
);
highResCover= base64.encode(fullSizeimageBytes);
// Then pass it to VideoMessage
|
b8a649f to
a983d1d
Compare
827803b to
4063c84
Compare
Contributor
Author
|
This PR is ready too. Like i said the
|
… HiRes images on his side)
cb9cea2 to
308213d
Compare
|
Is this ready to use? I might just take a couple of your patches onto a fork of mine to use, if that's okay? |
Contributor
Author
|
@Henry-Hiles i'm using it without any issue (but my app does not have many users). Code-wise it's ok, I was mostly discussing the default behavior/interface |
Contributor
Author
|
PS: (i may need some adjustement if the main branch moved a lot, did not pull in a while) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation notes
Maybe remaining points
ChatMessage(at least on the bubble). But if we want to prevent that the user would have to handle video playback.Recording.at.2025-06-03.00.17.18.mp4