Introduce GptMarkdownBuilder and wire into message widgets#844
Open
adar2378 wants to merge 1 commit intoflyerhq:mainfrom
Open
Introduce GptMarkdownBuilder and wire into message widgets#844adar2378 wants to merge 1 commit intoflyerhq:mainfrom
adar2378 wants to merge 1 commit intoflyerhq:mainfrom
Conversation
…troduce GptMarkdownBuilder and wire into message widgets - core (flutter_chat_core): - add typedef `GptMarkdownBuilder` in [src/utils/typedefs.dart](cci:7://file:///Users/saifulislam/Development/fleek/flutter_chat_ui/packages/flutter_chat_ui/lib/src/utils/typedefs.dart:0:0-0:0) - flyer_chat_text_message: - add optional `gptMarkdownBuilder` field/param - use builder to render Markdown when provided; fallback to `GptMarkdownTheme` + [GptMarkdown](cci:1://file:///Users/saifulislam/Development/fleek/flutter_chat_ui/packages/flyer_chat_text_stream_message/lib/src/flyer_chat_text_stream_message.dart:19:6-23:7) - flyer_chat_text_stream_message: - add optional `gptMarkdownBuilder` field/param - use builder in completed state and in `instantMarkdown` mode; fallback to [GptMarkdown](cci:1://file:///Users/saifulislam/Development/fleek/flutter_chat_ui/packages/flyer_chat_text_stream_message/lib/src/flyer_chat_text_stream_message.dart:19:6-23:7) Why: - Standardize Markdown customization via shared typedef - Allow consumers to fully override Markdown rendering consistently Affects: - packages/flutter_chat_core - packages/flyer_chat_text_message - packages/flyer_chat_text_stream_message BREAKING CHANGE: none
Contributor
Author
|
I have not run |
Member
|
hmm I am not sure I should merge this - how is it better from just copying message code you're interested in, and changing markdown rendering to what works for you? then using builders class to render your message instead of provided one? this was the idea behind |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Affects:
BREAKING CHANGE: none