Skip to content

Feat: Make RayCluster head node ingress optional #6852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fg91 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feat: Make RayCluster head node ingress optional #6852

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4adccc
Feat: Make RayCluster head node ingress optional
fg91 Jan 9, 2026
1f5adfd
Configure enableIngress in plugin config instead of task_config proto…
fg91 Jan 11, 2026
fe778f0
Merge branch 'master' into fg91/feat/make-ray-ingress-optional
fg91 Feb 10, 2026
a4280de
Disable ray ingress by default again and fix tests
fg91 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions flyteidl/gen/pb-es/flyteidl/plugins/ray_pb.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

86 changes: 49 additions & 37 deletions flyteidl/gen/pb-go/flyteidl/plugins/ray.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions flyteidl/gen/pb_python/flyteidl/plugins/ray_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions flyteidl/gen/pb_python/flyteidl/plugins/ray_pb2.pyi
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions flyteidl/gen/pb_rust/flyteidl.plugins.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions flyteidl/protos/flyteidl/plugins/ray.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ message HeadGroupSpec {
map<string, string> ray_start_params = 1;
// Pod Spec for the ray head pod
core.K8sPod k8s_pod = 2;

// Optional. Whether to enable an ingress on the ray cluster head node
bool enable_ingress = 3;
}

// WorkerGroupSpec are the specs for the worker pods
Expand Down
2 changes: 1 addition & 1 deletion flyteplugins/go/tasks/plugins/k8s/ray/ray.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ func (rayJobResourceHandler) BuildResource(ctx context.Context, taskCtx pluginsC
}

func constructRayJob(taskCtx pluginsCore.TaskExecutionContext, rayJob *plugins.RayJob, objectMeta *metav1.ObjectMeta, taskPodSpec v1.PodSpec, headNodeRayStartParams map[string]string, primaryContainerIdx int, primaryContainer v1.Container) (*rayv1.RayJob, error) {
enableIngress := true
enableIngress := rayJob.RayCluster.HeadGroupSpec.EnableIngress
cfg := GetConfig()

headPodSpec := taskPodSpec.DeepCopy()
Expand Down
Loading
Loading