Conversation
mwinterb
reviewed
Feb 4, 2026
doc/api.md
Outdated
| // Parses format specifiers and stores them in the formatter. | ||
| // | ||
| // [ctx.begin(), ctx.end()) is a, possibly empty, character range that | ||
| // (ctx.begin(), ctx.end()) is a, possibly empty, character range that |
Contributor
There was a problem hiding this comment.
The [ is an indicator of a half-open interval, not a parenthetical comment.
https://en.wikipedia.org/wiki/Interval_(mathematics)#Half-open_intervals
Contributor
Author
There was a problem hiding this comment.
My bad, didn't know about it
vitaut
reviewed
Feb 5, 2026
doc/api.md
Outdated
|
|
||
| `fmt/base.h` defines the base API which provides main formatting functions | ||
| for `char`/UTF-8 with C++20 compile-time checks. It has minimal include | ||
| for `char`/UTF-8, with C++20 compile-time checks. It has minimal include |
Contributor
There was a problem hiding this comment.
I don't think comma is needed here.
Contributor
Author
There was a problem hiding this comment.
yeah, I realized after submitting the pull request that it's not really needed there xd, already removed it
vitaut
reviewed
Feb 5, 2026
Contributor
vitaut
left a comment
vitaut
left a comment
There was a problem hiding this comment.
One small comment, otherwise LGTM.
Corrected formatting and grammar in the API documentation.
Contributor
|
Merged, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did some light cleanup in the docs: corrected mistakes, removed unnecessary repetitions, and fixed punctuation.