Validate full image name passed in for '--init-image'#433
Open
JadeRedworth wants to merge 1 commit intofnproject:masterfrom
Open
Validate full image name passed in for '--init-image'#433JadeRedworth wants to merge 1 commit intofnproject:masterfrom
JadeRedworth wants to merge 1 commit intofnproject:masterfrom
Conversation
JadeRedworth
force-pushed
the
init-image-name-fix
branch
2 times, most recently
from
836b8cf to
6b035dc
Compare
JadeRedworth
force-pushed
the
init-image-name-fix
branch
from
6b035dc to
2771731
Compare
riconnon
suggested changes
Sep 26, 2018
Contributor
riconnon
left a comment
riconnon
left a comment
There was a problem hiding this comment.
Looks like this broke the init-image test. I assume the test is failing the validation.
However, we should also add a test which deliberately uses an invalid image and checks for the expected error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #406 --init-image should fail if no correct image has been provided