Add external format validators option#85
Open
abogosyan wants to merge 5 commits intofor-GET:masterfrom
Open
Conversation
seriyps
reviewed
Oct 31, 2019
Contributor
seriyps
left a comment
There was a problem hiding this comment.
Thanks for your PR! I Added some notes. No "critical" issues, just something to discuss.
Contributor
|
Oh, sorry, I completely forgot about two other things:
|
Author
Will do, when i have free time :( |
Author
|
Finally, I've added few tests and little readme, also fixed linter errors and made compatible for erlang versions without maps support, please check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is similar to
external_validatoroptionThis option allows you to define own string formats and validate it with any
fun(binary()) -> ok | error.For example:
And somewhere in schema: