Skip to content

Potential fix for race condition in SFRestAPI#3993

Draft
bbirman wants to merge 1 commit intoforcedotcom:devfrom
bbirman:rest
Draft

Potential fix for race condition in SFRestAPI#3993
bbirman wants to merge 1 commit intoforcedotcom:devfrom
bbirman:rest

Conversation

@bbirman
Copy link
Member

@bbirman bbirman commented Feb 24, 2026

No description provided.

@github-actions
Copy link

1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SFRestAPI Nullability Memory error nil assigned to a pointer which is expected to have non-null value 98 5

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.22%. Comparing base (4cc9432) to head (cc6d2b9).
⚠️ Report is 48 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3993      +/-   ##
==========================================
- Coverage   52.30%   52.22%   -0.08%     
==========================================
  Files         191      191              
  Lines       15686    15687       +1     
==========================================
- Hits         8204     8192      -12     
- Misses       7482     7495      +13     
Components Coverage Δ
Analytics 40.00% <ø> (-0.99%) ⬇️
Common 56.22% <ø> (ø)
Core 52.28% <100.00%> (-0.06%) ⬇️
SmartStore ∅ <ø> (∅)
MobileSync ∅ <ø> (∅)
Files with missing lines Coverage Δ
...Core/SalesforceSDKCore/Classes/RestAPI/SFRestAPI.m 85.59% <100.00%> (+0.03%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^26 Test Results586 ran584 ✅2 ❌
TestResult
SalesforceSDKCore iOS ^26 Test Results
DevInfoViewControllerTests.testDevInfoViewRendersRealWorldData()❌ failure
SalesforceRestAPITests.testUploadOwnedFilesDelete (failure 1/3)❌ failure
SalesforceRestAPITests.testUploadOwnedFilesDelete (failure 2/3)❌ failure
SalesforceRestAPITests.testUploadOwnedFilesDelete (failure 3/3)❌ failure

@github-actions
Copy link

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^18 Test Results586 ran584 ✅2 ❌
TestResult
SalesforceSDKCore iOS ^18 Test Results
DevInfoViewControllerTests.testDevInfoViewRendersRealWorldData()❌ failure
DomainDiscoveryCoordinatorTests.testExtraQueryParameters()❌ failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants