Merged
Conversation
KaviarasuSakthivadivel
previously approved these changes
Apr 9, 2025
KaviarasuSakthivadivel
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to reduce the number of third party libraries contaminating
jdbc-coreas well as streamlining its functionality to be more a bridge between the Query V3 gRPC API and the JDBC spec, we've pulled out some okhttp code for auth and metadata as well as some utilties out into their own respective librariesjdbc-httpandjdbc-util.As a result of this refactor
DataCloudConnectionandDataCloudDatabaseMetadataknow far less about details like OAuth and SOQL queries, these are instead provided with reduced coupling through gRPCClientInterceptorand metadata suppliers implementingThrowingJdbcSupplier, these are expected to be provided throughDataCloudConnection::fromOauth