Skip to content

feat(crds): add configurable annotations#385

Merged
Dav-14 merged 1 commit intomainfrom
feat/add_crd_annotation
Feb 3, 2026
Merged

feat(crds): add configurable annotations#385
Dav-14 merged 1 commit intomainfrom
feat/add_crd_annotation

Conversation

@Dav-14
Copy link
Contributor

@Dav-14 Dav-14 commented Feb 3, 2026

No description provided.

@Dav-14 Dav-14 requested a review from a team as a code owner February 3, 2026 11:19
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

Walkthrough

The helm-update target in the Justfile is enhanced with bash strict mode (shebang and pipefail) and a new loop that patches all CRD YAML files under helm/crds/templates/crds/ by inserting Helm annotations and rendering directives after controller-gen version lines.

Changes

Cohort / File(s) Summary
Justfile helm-update target
Justfile
Added bash shebang and pipefail handling; introduced loop to patch CRD YAML files with helm.sh/resource-policy annotation and values rendering snippet positioned after controller-gen.kubebuilder.io/version markers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Whiskers twitch with delight,
CRDs now patched just right,
Annotations dance in the Helm winds,
Build scripts gleam as the loop spins,
One little script, such power it finds!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether the description relates to the changeset. Add a pull request description that explains the purpose, motivation, and impact of adding configurable annotations to CRD files.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat(crds): add configurable annotations' accurately describes the main change: adding configurable annotations to CRD YAML files through a new patching mechanism in the helm-update target.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/add_crd_annotation

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@Justfile`:
- Around line 44-45: The line containing the token "set pipefail -e" is using
incorrect syntax and is assigning positional parameters instead of enabling
shell options; replace that line with a proper set invocation that enables
errexit and pipefail (for example, use the -e flag and the -o pipefail option or
the combined -eo pipefail form) and consider adding -u to treat unset variables
as errors so the script fails fast.

@Dav-14 Dav-14 merged commit d4b734e into main Feb 3, 2026
6 checks passed
@Dav-14 Dav-14 deleted the feat/add_crd_annotation branch February 3, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants