Add validation for op argument in spmv routine for special matrices

[Mahmood-Sinan]

This pr adds validation for the optional argument op in stdlib_specialmatrices.
When op is present and not one of N, T, or C, a LINALG_VALUE_ERROR is raised using linalg error handling.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.55%. Comparing base (a2065bb) to head (1b3e3fc).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1087      +/-   ##
==========================================
+ Coverage   68.51%   68.55%   +0.03%     
==========================================
  Files         396      396              
  Lines       12746    12746              
  Branches     1376     1376              
==========================================
+ Hits         8733     8738       +5     
+ Misses       4013     4008       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[loiseaujc]

If I recall correctly, the sparse matrix-vector product accepts H as input as well for the complex-conjugate matrix-vector product. Maybe you could extend the validation to include it and internally handles the fact that H and C are equivalent.

[Mahmood-Sinan]

If I recall correctly, the sparse matrix-vector product accepts H as input as well for the complex-conjugate matrix-vector product. Maybe you could extend the validation to include it and internally handles the fact that H and C are equivalent.

@loiseaujc I have made the changes. The routine now accepts H and maps it internally to C before calling lagtm, since only C is supported there.

[loiseaujc]

LGTM.

[jalvesz]

this is looking good. It might be good to add a quick test to check that the error is properly catched when op is different than the expected options.

[Mahmood-Sinan]

this is looking good. It might be good to add a quick test to check that the error is properly catched when op is different than the expected options.

Thanks for the suggestion!
I looked into adding a negative test, but spmv calls linalg_error_handling in case of invalid op, which triggers an error stop. I think since this aborts the test executable, the error path cannot be caught.

[jvdp1]

Thank you @Mahmood-Sinan . This PR looks good. I will merge it. Could you first fix the merge conflit please?

[Mahmood-Sinan]

Thank you @Mahmood-Sinan . This PR looks good. I will merge it. Could you first fix the merge conflit please?

Thank you. I have fixed the merged conflict.

[loiseaujc]

LGTM.

[jvdp1]

LGTM. Thank you @Mahmood-Sinan