feat: add Dust Sensor instrument screen #3030

manishraj-003 · 2026-01-18T19:36:48Z

Fixes #2988

Changes

Added Dust Sensor instrument to Instruments list
Implemented Dust Sensor screen UI (Particles PPM, Air Quality, gauge and chart placeholder)
Added route mapping for /dustsensor

Screenshots / Recordings

Checklist:

No hard coding: I have used values from constants.dart or localization files instead of hard-coded values.
No end of file edits: No modifications done at end of resource files.
Code reformatting: I have formatted the code using dart format or the IDE formatter.
Code analysis: My code passes checks run in flutter analyze and tests run in flutter test.

sourcery-ai

Sorry @manishraj-003, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

github-actions · 2026-01-18T19:53:59Z

Build Status

Build successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/21117901987/artifacts/5170267588.

Screenshots

Android Screenshots

iPhone Screenshots

iPad Screenshots

Yugesh-Kumar-S · 2026-01-19T14:37:17Z

Hi @manishraj-003 ,please make use of the guide_widget.dart for the meter .It would help to maintain consistent UI.

Copilot

Pull request overview

Adds a new Dust Sensor instrument entry and a corresponding Flutter screen to bring feature parity with the legacy Java app (issue #2988), including navigation wiring and initial UI scaffolding.

Changes:

Enabled “Dust Sensor” in the Instruments list and added a /dustsensor route.
Added DustSensorScreen UI (PPM/air-quality display, gauge, and chart area).
Introduced DustSensorStateProvider for screen state and (placeholder) streaming behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
lib/view/instruments_screen.dart	Adds Dust Sensor to the instruments list for navigation.
lib/view/dust_sensor_screen.dart	New Dust Sensor UI screen with menu actions, gauge, and chart placeholder.
lib/providers/dust_sensor_state_provider.dart	New state provider for dust sensor value/graph and streaming lifecycle.
lib/main.dart	Registers the Dust Sensor route and imports the screen.
lib/constants.dart	Adjusts instrument icon list to include a temporary dust/sound icon entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-08T16:54:18Z

lib/providers/dust_sensor_state_provider.dart

+    // TODO: Replace timer body with real sensor reading.
+    // Example future flow:
+    // 1) Read dust sensor value from PSLab
+    // 2) _ppm = newValue
+    // 3) _spots.add(FlSpot(_time, _ppm!))
+    // 4) _time += 1
+    // 5) notifyListeners()
+
+    _timer = Timer.periodic(const Duration(milliseconds: 700), (_) {
+      // No mock values in perfect PR.
+      // Keep running idle until real data integration is added.
+      notifyListeners();
+    });
+


Timer.periodic calls notifyListeners() every 700ms without changing any state. That will force continuous rebuilds and waste battery/CPU. Until real sensor integration exists, consider not starting a timer at all (or only notify when a new reading is actually added/changed).

Suggested change

// TODO: Replace timer body with real sensor reading.

// Example future flow:

// 1) Read dust sensor value from PSLab

// 2) _ppm = newValue

// 3) _spots.add(FlSpot(_time, _ppm!))

// 4) _time += 1

// 5) notifyListeners()

_timer = Timer.periodic(const Duration(milliseconds: 700), (_) {

// No mock values in perfect PR.

// Keep running idle until real data integration is added.

notifyListeners();

});

// TODO: Replace this placeholder with real sensor reading.

// Example future flow:

// 1) Read dust sensor value from PSLab

// 2) _ppm = newValue

// 3) _spots.add(FlSpot(_time, _ppm!))

// 4) _time += 1

// 5) notifyListeners()

//

// Until real sensor integration is implemented, avoid starting a

// periodic timer that triggers rebuilds without any state changes.

Copilot · 2026-02-08T16:54:19Z

lib/view/dust_sensor_screen.dart

+    if (ppm < 1.0) return "Good";
+    if (ppm < 2.5) return "Moderate";
+    if (ppm < 4.0) return "Poor";
+    return "Hazardous";


Air-quality labels are hard-coded English strings (Good/Moderate/Poor/Hazardous). These should come from AppLocalizations so the screen is translatable like the rest of the app, and so the PR checklist claim of no hard-coded strings holds.

Suggested change

if (ppm < 1.0) return "Good";

if (ppm < 2.5) return "Moderate";

if (ppm < 4.0) return "Poor";

return "Hazardous";

final loc = AppLocalizations.of(context)!;

if (ppm < 1.0) return loc.airQualityGood;

if (ppm < 2.5) return loc.airQualityModerate;

if (ppm < 4.0) return loc.airQualityPoor;

return loc.airQualityHazardous;

Copilot · 2026-02-08T16:54:19Z

lib/view/dust_sensor_screen.dart

+                      const PopupMenuItem(
+                        value: 'clear',
+                        child: Text("Clear graph"),
+                      ),
+                      PopupMenuItem(
+                        value: 'toggle',
+                        enabled: connected,
+                        child: Text(provider.isStreaming ? "Stop" : "Start"),
+                      ),


The options menu items use hard-coded strings (e.g., "Clear graph", "Start"/"Stop"). Please replace these with localized strings (ARB + generated getters) to match the app’s localization pattern.

Copilot · 2026-02-08T16:54:19Z

lib/view/dust_sensor_screen.dart

+                        Text(
+                          "⚠️ Connect PSLab device to start measuring.",
+                          style: Theme.of(context).textTheme.bodySmall,


This user-facing message is hard-coded and includes an emoji. For localization and accessibility/screen-reader consistency, use a localized string (and consider using an Icon widget instead of an emoji if you want a warning indicator).

Suggested change

Text(

"⚠️ Connect PSLab device to start measuring.",

style: Theme.of(context).textTheme.bodySmall,

Row(

mainAxisAlignment: MainAxisAlignment.center,

children: [

Icon(

Icons.warning_amber_rounded,

size: 16,

color: Theme.of(context).colorScheme.error,

),

const SizedBox(width: 8),

Text(

"Connect PSLab device to start measuring.",

style: Theme.of(context).textTheme.bodySmall,

),

],

Copilot · 2026-02-08T16:54:19Z

lib/constants.dart

@@ -26,9 +26,8 @@ List<String> instrumentIcons = [
  'assets/icons/gyroscope_logo.png',
  'assets/icons/thermometer_logo.png',
  'assets/icons/robotic_arm.png',


instrumentIcons now has fewer entries than instrumentNames, and it also changes the assumed index mapping used elsewhere (e.g., instrumentIcons[15] in SoundMeter and LoggedDataScreen’s instrumentNames.indexOf(...) lookup). This can cause RangeError crashes and/or wrong icons. Keep instrumentIcons and instrumentNames aligned (same ordering/length), or refactor to a keyed mapping so screens don’t rely on hard-coded indices.

Suggested change

'assets/icons/robotic_arm.png',

'assets/icons/robotic_arm.png',

'assets/icons/tile_icon_gas.png', // gas/dust sensor (temporary icon)

Copilot · 2026-02-08T16:54:20Z

lib/view/dust_sensor_screen.dart

+    return ChangeNotifierProvider(
+      create: (_) => DustSensorStateProvider(),
+      child: Consumer<DustSensorStateProvider>(
+        builder: (context, provider, _) {


ChangeNotifierProvider(create: ...) is inside build(), so any rebuild of DustSensorScreen (e.g., toggling _showGuide) will recreate DustSensorStateProvider and reset state/timers/spots. Instantiate the provider once (e.g., in initState as a late final field) and provide it via ChangeNotifierProvider.value, or lift the provider above this widget (route-level provider).

Copilot · 2026-02-08T16:54:20Z

lib/view/dust_sensor_screen.dart

+            provider.stop();
+            provider.clearGraph();


Calling provider.stop() / provider.clearGraph() from inside the Consumer builder introduces side effects during build and can trigger "markNeedsBuild called during build" style issues (notifyListeners while building). Move this disconnect cleanup into a listener (addListener/Selector) or schedule it post-frame when the connection state transitions.

Suggested change

provider.stop();

provider.clearGraph();

// Avoid side effects during build: schedule stop/clear after this frame.

WidgetsBinding.instance.addPostFrameCallback((_) {

if (!mounted) return;

final dustProvider = context.read<DustSensorStateProvider>();

if (! _isDeviceConnected() && dustProvider.isStreaming) {

dustProvider.stop();

dustProvider.clearGraph();

}

});

Copilot · 2026-02-08T16:54:20Z

lib/providers/dust_sensor_state_provider.dart

+  /// Starts polling/streaming dust values.
+  /// In this PR we only enable the UI + route; hardware streaming will be added later.
+  void start() {
+    if (_isStreaming || !_isConnected) return;


start() is gated on _isConnected, but nothing in this PR ever calls setConnectionStatus(true). As a result, start() will always early-return and streaming can never begin even when the device is connected. Either remove _isConnected from the provider and rely on the UI’s connected check, or ensure the UI updates the provider’s connection state when ScienceLab.isConnected() changes.

Suggested change

if (_isStreaming || !_isConnected) return;

if (_isStreaming) return;

sourcery-ai bot reviewed Jan 18, 2026

View reviewed changes

github-actions bot added a commit that referenced this pull request Jan 18, 2026

[Auto] Update screenshots for #3030 (2026-01-18.19:53:57)

60ac690

manishraj-003 force-pushed the issue2988 branch from 0fd7067 to 4184be9 Compare January 18, 2026 19:56

feat: add Dust Sensor instrument screen

296f99b

github-actions bot added a commit that referenced this pull request Jan 18, 2026

[Auto] Update screenshots for #3030 (2026-01-18.20:11:04)

1f92f8c

manishraj-003 force-pushed the issue2988 branch from 4184be9 to 296f99b Compare January 18, 2026 20:11

github-actions bot added a commit that referenced this pull request Jan 18, 2026

[Auto] Update screenshots for #3030 (2026-01-18.20:28:05)

b958ab9

marcnause requested a review from Copilot February 8, 2026 16:49

Copilot started reviewing on behalf of marcnause February 8, 2026 16:50 View session

Copilot AI reviewed Feb 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add Dust Sensor instrument screen #3030

feat: add Dust Sensor instrument screen #3030

manishraj-003 commented Jan 18, 2026 •

edited

Loading

Uh oh!

sourcery-ai bot left a comment

Uh oh!

github-actions bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

Yugesh-Kumar-S commented Jan 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 8, 2026

Uh oh!

Copilot AI Feb 8, 2026

Uh oh!

Copilot AI Feb 8, 2026

Uh oh!

Copilot AI Feb 8, 2026

Uh oh!

Copilot AI Feb 8, 2026

Uh oh!

Copilot AI Feb 8, 2026

Uh oh!

Copilot AI Feb 8, 2026

Uh oh!

Copilot AI Feb 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-    if (ppm < 1.0) return "Good";
-    if (ppm < 2.5) return "Moderate";
-    if (ppm < 4.0) return "Poor";
-    return "Hazardous";
+    final loc = AppLocalizations.of(context)!;
+    if (ppm < 1.0) return loc.airQualityGood;
+    if (ppm < 2.5) return loc.airQualityModerate;
+    if (ppm < 4.0) return loc.airQualityPoor;
+    return loc.airQualityHazardous;

-                        Text(
-                          "⚠️ Connect PSLab device to start measuring.",
-                          style: Theme.of(context).textTheme.bodySmall,
+                        Row(
+                          mainAxisAlignment: MainAxisAlignment.center,
+                          children: [
+                            Icon(
+                              Icons.warning_amber_rounded,
+                              size: 16,
+                              color: Theme.of(context).colorScheme.error,
+                            ),
+                            const SizedBox(width: 8),
+                            Text(
+                              "Connect PSLab device to start measuring.",
+                              style: Theme.of(context).textTheme.bodySmall,
+                            ),
+                          ],

	'assets/icons/robotic_arm.png',
	'assets/icons/robotic_arm.png',
	'assets/icons/tile_icon_gas.png', // gas/dust sensor (temporary icon)

-            provider.stop();
-            provider.clearGraph();
+            // Avoid side effects during build: schedule stop/clear after this frame.
+            WidgetsBinding.instance.addPostFrameCallback((_) {
+              if (!mounted) return;
+              final dustProvider = context.read<DustSensorStateProvider>();
+              if (! _isDeviceConnected() && dustProvider.isStreaming) {
+                dustProvider.stop();
+                dustProvider.clearGraph();
+              }
+            });

	if (_isStreaming \|\| !_isConnected) return;
	if (_isStreaming) return;

feat: add Dust Sensor instrument screen #3030

Are you sure you want to change the base?

feat: add Dust Sensor instrument screen #3030

Conversation

manishraj-003 commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Screenshots / Recordings

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Status

Screenshots

Uh oh!

Yugesh-Kumar-S commented Jan 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

manishraj-003 commented Jan 18, 2026 •

edited

Loading

github-actions bot commented Jan 18, 2026 •

edited

Loading