fix(binder): Use minimum of startLine and endLine#63
Merged
Kaushl2208 merged 1 commit intofossology:masterfrom Jul 23, 2025
Merged
fix(binder): Use minimum of startLine and endLine#63Kaushl2208 merged 1 commit intofossology:masterfrom
Kaushl2208 merged 1 commit intofossology:masterfrom
Conversation
hastagAB
approved these changes
Jul 6, 2025
Member
|
Hey @rajuljha , Just a quick question with the example you pasted: here in |
Contributor
Author
|
Oh, I see the problem now, the reason the endLine and startLine length's dont match is because of this: It is treating the "*/" symbol in the code as a end of a comment. We haven't handled this in code yet. I'll fix this. |
… endLine Fixes fossology#62 Signed-off-by: Rajul Jha <rajuljha49@gmail.com>
Contributor
Author
Fixed it! Thanks for spotting that @Kaushl2208 :) |
Kaushl2208
approved these changes
Jul 6, 2025
Member
Kaushl2208
left a comment
Kaushl2208
left a comment
There was a problem hiding this comment.
Cool man, Changes looks good now :)
Thanks for handling this in much better way.
Will give it a test. :)
Member
|
Tested, Working as expected!! Thanks @rajuljha for the fix :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check valid pairs of startLine and endLine comments before indexing as a list.
Fixes #62
Screenshot of the fix:
