Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 146 146
Lines 3881 3914 +33
=====================================
- Misses 3881 3914 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Schamper
requested changes
Feb 3, 2026
Member
Schamper
left a comment
There was a problem hiding this comment.
Maybe add a benchmark test too? I'll look at the actual checksum checking part later when I have a bit more time.
| fh: Path | BinaryIO, | ||
| wal: WAL | Path | BinaryIO | None = None, | ||
| checkpoint: Checkpoint | int | None = None, | ||
| validate_checksum: bool = False, |
Member
There was a problem hiding this comment.
Suggested change
| validate_checksum: bool = False, | |
| *, | |
| validate_checksums: bool = False, |
Can you also add it to the docstring?
|
|
||
| @property | ||
| def valid(self) -> bool: | ||
| def valid(self, validate_checksum: bool = True) -> bool: |
Member
There was a problem hiding this comment.
Maybe change this to a verb-style name now that it's a method. is_valid?
Comment on lines
+140
to
+141
| def validate_salt(self) -> bool: | ||
| """Check if the frame's salt values match those in the WAL header. |
Member
There was a problem hiding this comment.
Suggested change
| def validate_salt(self) -> bool: | |
| """Check if the frame's salt values match those in the WAL header. | |
| def is_valid_salt(self) -> bool: | |
| """Return whether the frame's salt values match those in the WAL header. |
Comment on lines
+151
to
+152
| def validate_checksum(self) -> bool: | ||
| """Check if the frame's checksum matches the calculated checksum. |
Member
There was a problem hiding this comment.
Suggested change
| def validate_checksum(self) -> bool: | |
| """Check if the frame's checksum matches the calculated checksum. | |
| def is_valid_checksum(self) -> bool: | |
| """Return whether the frame's checksum matches the calculated checksum. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR close #16 by expanding the data validation capabilities in SQLite3.
The SQLite3 WAL file can store multiple versions of the same frame, when reading only valid frames should be returned. The docs define a valid frame as follows:
The first check was already implemented, I have interpreted the second check as:
When initializing a database the option
validate_checksumcan be passed to use the new validation. I have chosen to only calculate the salts by default (just like before) as this will probably be good enough, and a lot faster. See the example below for the time impact: