Improve ESXiPlugin support for recent version#1509
Open
william-billaud wants to merge 17 commits intofox-it:mainfrom
Open
Improve ESXiPlugin support for recent version#1509william-billaud wants to merge 17 commits intofox-it:mainfrom
william-billaud wants to merge 17 commits intofox-it:mainfrom
Conversation
Schamper
requested changes
Jan 21, 2026
| @export(record=[ESXiUserRecord, UnixUserRecord]) | ||
| def users(self) -> Iterator[ESXiUserRecord | UnixUserRecord]: | ||
| if self.version and self.version[0] < "7": | ||
| yield from super().users(sessions=False) |
Member
There was a problem hiding this comment.
Maybe just extract the information from the UnixUserRecord and put it in a new ESXiUserRecord so that we only have that as return type.
Contributor
Author
There was a problem hiding this comment.
Will do, after further analysis, /etc/passwd is still present in ESXi7+, just not collected by vmsupport/available from raw disk (probably located in local.tgz.ve). Thus I will merge both entries if available.
Fix user plugins and test
william-billaud
added a commit
to william-billaud/dissect.target
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance ESXiOs plugin, especially for non disk collection.
local.tgz.ve: Warning was issued even if decryption worked properly.Other changes
Note
Test on raw disk
hostname,os,domain,version,ips
users (/etc/passwd is not found)