fix(acms): Updates logic to support PDF uploads from new modal #423

ERosendo · 2026-02-07T04:14:52Z

What does this PR do?

Adds support to intercept PDF downloads from the new ACMS download confirmation modal and upload them to the RECAP Archive.

The new version of ACMS renders a download confirmation modal when a user clicks a document link on the docket page. The modal does not include the docket entry ID or document name in its HTML, so there’s no way to tell which document was clicked using the DOM alone.

On top of that, the modal always displays "Document 1" regardless of which docket entry is actually selected. If the extension relied on parsing this HTML to identify the document, it would incorrectly associate all downloads with docket entry 1, mixing up PDFs from different entries and causing data integrity issues (see freelawproject/recap#401 (comment))

To solve this, this PR introduces a background script function (getDocumentDataFromDownloadModal) that injects a script into the page context to access the DownloadConfirmation instance via window.showDocPageInitializer.modalManager.currentComponent and extracts the docketEntryId and docketEntryDocuments. The data is stored in sessionStorage as a bridge between the page context and the extension's content script.

Changes

Add getDocumentDataFromDownloadModal() to extract document data from the page context via script injection
Refactor handleAcmsDownloadPage into focused helper methods:
- isDownloadConfirmationModal: checks if the modal is a billable download page
- resolveDocumentData: consolidates duplicated logic for looking up the docket entry and document from sessionStorage
- replaceAcceptChargesButton: swaps the default button with one that intercepts the download for RECAP upload (the original PDF URL is one-time-use)
- startUploadProcess: fetches the PDF via the merge API and hands the blob to handleDocFormResponse for upload
- insertRecapBannerIfAvailable: queries the RECAP archive and displays a centered download banner if a cached copy exists

When a user clicks a document link on the ACMS docket page, ACMS opens a download confirmation modal. The modal does not render the docket entry ID or document name in its HTML, making it impossible to determine which docket entry was clicked from the DOM alone. This commit adds getDocumentDataFromDownloadModal, which injects a script into the page context to access the DownloadConfirmation instance via window.showDocPageInitializer.modalManager.currentComponent and extracts the docketEntryId and docketEntryDocuments. The data is stored in sessionStorage as a bridge between the page context and the extension's content script.

Refactor handleAcmsDownloadPage to support intercepting PDF downloads from the ACMS download confirmation modal and sending them to the RECAP archive. This refactor breaks the code into focused helper methods: - `isDownloadConfirmationModal`: checks if the modal is a billable download page - `resolveDocumentData`: centralizes logic for looking up the docket entry and specific document from sessionStorage - `replaceAcceptChargesButton`: swaps the default button with one that intercepts the download so we can fetch the PDF as a blob for RECAP upload - `startUploadProcess`: fetches the PDF via the merge API and hands the blob to handleDocFormResponse for upload. - `insertRecapBannerIfAvailable`: queries the RECAP archive and displays a centered download banner if a copy exists

albertisfu

Thanks @ERosendo this looks good. I only found a potential issue and some code suggestions.

albertisfu · 2026-02-11T15:21:32Z

src/appellate/appellate.js

+      (entry) => entry.docketEntryId == downloadData.docketEntryId
+    );
+
+    if (!docketEntryData.docketEntryDocuments.length) {


Would it be possible for docketEntryData and docketEntryDocuments to be null? In that case, the .length condition would fail.

Suggested change

if (!docketEntryData.docketEntryDocuments.length) {

if (!docketEntryData?.docketEntryDocuments?.length) {

albertisfu · 2026-02-11T15:21:37Z

src/appellate/appellate.js

+    // For entries with multiple attachments, match on the specific document
+    // that was clicked. For single-document entries, use the only document.
+    let documentData;
+    if (docketEntryData.docketEntryDocuments.length > 1) {


Similar suggestion:

Suggested change

if (docketEntryData.docketEntryDocuments.length > 1) {

if (docketEntryData?.docketEntryDocuments?.length > 1) {

albertisfu · 2026-02-11T15:22:37Z

src/appellate/appellate.js

+    return { docketEntryData, documentData };
+  };
+
+  insertRecapBannerIfAvailable = async (docketEntryData, documentData) => {


missing const?

Suggested change

insertRecapBannerIfAvailable = async (docketEntryData, documentData) => {

const insertRecapBannerIfAvailable = async (docketEntryData, documentData) => {

albertisfu · 2026-02-11T15:27:46Z

src/appellate/appellate.js

+        (obj) => obj.acms_document_guid == documentData.docketDocumentDetailsId
+      );
+    } else {
+      result = recapLinks.results[0];


I noticed an issue that occurs under the following conditions:

The entry contains attachments.

One of the attachments is available.

In that case, the RECAP banner on the download confirmation page is shown for both documents, but it points to the same available document.

I think the problem is on this line.

If only one document is available but there are multiple documents in the entry, the same document banner is injected into all of them. We may need to verify that the document returned is the same one being displayed on the download confirmation page.

albertisfu · 2026-02-11T15:27:57Z

src/appellate/appellate.js

+
+    // Insert the banner inside the centered wrapper
+    insertAvailableDocBanner(result.filepath_local, wrapper);
+  };;


Suggested change

};;

};

albertisfu · 2026-02-11T15:29:00Z

src/appellate/appellate.js

+      (entry) => entry.docketEntryId == downloadData.docketEntryId
    );
+
+    if (!docketEntryData.docketEntryDocuments.length) return;


Suggested change

if (!docketEntryData.docketEntryDocuments.length) return;

if (!docketEntryData?.docketEntryDocuments?.length) return;

albertisfu · 2026-02-11T15:30:14Z

src/appellate/appellate.js

+    let mainDiv = modal.querySelector('.modal-body');
    mainDiv.innerHTML = '';
-    loadingTextMessage = APPELLATE.createsLoadingMessage(downloadData);
+    loadingTextMessage = APPELLATE.createsLoadingMessage(caseNumber);


missing var defintion:

Suggested change

loadingTextMessage = APPELLATE.createsLoadingMessage(caseNumber);

let loadingTextMessage = APPELLATE.createsLoadingMessage(caseNumber);

albertisfu · 2026-02-11T15:31:26Z

src/appellate/appellate.js

+
+    newButton.addEventListener(
+      'click',
+      startUploadProcess.bind(this, modal, docketEntryData, documentData)


We are passing parameters to startUploadProcess, but the method does not receive them. They appear to be unused.

albertisfu · 2026-02-11T15:32:52Z

src/utils/background.js

+        'recapDownloadDocumentData',
+        JSON.stringify({
+          docketEntryId: null,
+          documentName: null,


I didn’t find documentName being used anywhere else. Should it be?

Suggested change

documentName: null,

docketEntryDocuments: null,

ERosendo added 5 commits February 6, 2026 14:07

feat(appellate): Updates getAndStoreMetaData to store full object

eb92ec4

fix(acms): Skips links with no matching docket entry

777cca1

feat(docs): Updates the changes.md file

9f162ec

ERosendo force-pushed the 401-fix-acms-logic-to-upload-pdfs branch from fd64738 to 9f162ec Compare February 8, 2026 20:37

ERosendo marked this pull request as ready for review February 8, 2026 20:39

ERosendo requested a review from mlissner February 8, 2026 20:39

ERosendo assigned mlissner Feb 8, 2026

ERosendo added this to Sprint (Web Team) Feb 8, 2026

ERosendo moved this to To Do in Sprint (Web Team) Feb 8, 2026

mlissner requested review from albertisfu and removed request for mlissner February 9, 2026 00:44

mlissner assigned albertisfu and unassigned mlissner Feb 9, 2026

ERosendo mentioned this pull request Feb 9, 2026

9th Circuit Dockets/Documents Not Uploading to RECAP freelawproject/recap#401

Open

albertisfu moved this from To Do to In progress in Sprint (Web Team) Feb 9, 2026

ERosendo mentioned this pull request Feb 10, 2026

ACMS document links broken freelawproject/courtlistener#6614

Open

albertisfu requested changes Feb 11, 2026

View reviewed changes

albertisfu moved this from In progress to To Do in Sprint (Web Team) Feb 11, 2026

albertisfu assigned ERosendo and unassigned albertisfu Feb 11, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(acms): Updates logic to support PDF uploads from new modal #423

fix(acms): Updates logic to support PDF uploads from new modal #423

ERosendo commented Feb 7, 2026 •

edited

Loading

Uh oh!

albertisfu left a comment

Uh oh!

albertisfu Feb 11, 2026

Uh oh!

albertisfu Feb 11, 2026

Uh oh!

albertisfu Feb 11, 2026

Uh oh!

albertisfu Feb 11, 2026

Uh oh!

albertisfu Feb 11, 2026

Uh oh!

albertisfu Feb 11, 2026

Uh oh!

albertisfu Feb 11, 2026

Uh oh!

albertisfu Feb 11, 2026

Uh oh!

albertisfu Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	if (!docketEntryData.docketEntryDocuments.length) {
	if (!docketEntryData?.docketEntryDocuments?.length) {

	if (docketEntryData.docketEntryDocuments.length > 1) {
	if (docketEntryData?.docketEntryDocuments?.length > 1) {

	insertRecapBannerIfAvailable = async (docketEntryData, documentData) => {
	const insertRecapBannerIfAvailable = async (docketEntryData, documentData) => {

	loadingTextMessage = APPELLATE.createsLoadingMessage(caseNumber);
	let loadingTextMessage = APPELLATE.createsLoadingMessage(caseNumber);

Uh oh!

fix(acms): Updates logic to support PDF uploads from new modal #423

Are you sure you want to change the base?

fix(acms): Updates logic to support PDF uploads from new modal #423

Conversation

ERosendo commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Changes

Uh oh!

albertisfu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ERosendo commented Feb 7, 2026 •

edited

Loading