Fix TypeError in number increment/decrement services when entity.value is string#986
Draft
Fix TypeError in number increment/decrement services when entity.value is string#986
Conversation
…e is string Co-authored-by: frenck <195327+frenck@users.noreply.github.com>
|
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Copilot
AI
changed the title
[WIP] Unknown error in number.increment
Fix TypeError in number increment/decrement services when entity.value is string
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The
number.incrementandnumber.decrementservices were failing with a TypeError when used with number entities that return theirvalueproperty as a string instead of a numeric type.The Problem
Some integrations (like the dreo integration) return the entity value as a string representation rather than a numeric type. This caused the following error:
The error occurred in these lines:
increment.pyline 39:value = entity.value + amountdecrement.pyline 39:value = entity.value - amountThe Solution
Convert
entity.valuetofloatbefore performing arithmetic operations:increment.py:value = float(entity.value) + amountdecrement.py:value = float(entity.value) - amountThis ensures type compatibility while maintaining backward compatibility with entities that already return numeric types.
Testing
The fix has been validated with:
Fixes #985.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.