chore(package.json): remove redundant react-dnd dependency#881
Open
benatshippabo wants to merge 1 commit intofrontend-collective:masterfrom
Open
chore(package.json): remove redundant react-dnd dependency#881benatshippabo wants to merge 1 commit intofrontend-collective:masterfrom
benatshippabo wants to merge 1 commit intofrontend-collective:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
If left alone, it causes a headache when trying to meet the peer dependency
^7.3.0when it doesn't reflect the actual version being used byreact-sortable-tree. Juggling with@types/react-sortable-treethere are three separatereact-dndversion requirements. And having multiple version ofreact-dndwill lead to runtime errors.Fix
Removed
react-dndfrompeerDependenciessince we already declaredreact-dndas a normal dependency 🤔