Add Sarif output support to FSharpLint.Console#702
Add Sarif output support to FSharpLint.Console#702Numpsy wants to merge 3 commits intofsprojects:masterfrom
Conversation
|
It might also be possible to make it generate a sarif report from the |
|
Rebased on top of the latest code (The Paket changes are gone now, so previous comments about that don't apply any more |
xperiandri
left a comment
There was a problem hiding this comment.
Looks good, use object initializers, please
|
Rebased to fix conflicts, haven't got to the other comments yet. |
|
Resolves #554 |
95320fc to
02456e1
Compare
02456e1 to
1a366ef
Compare
cd9f340 to
2ef09de
Compare
| let result = | ||
| Result( | ||
| RuleId = reportDescriptor.Id, | ||
| Level = FailureLevel.Warning, |
There was a problem hiding this comment.
If there aren't different levels for different rules, should the default here be Warning or Note?
|
Any other comments on the general idea? |
2ef09de to
dd48266
Compare
dd48266 to
68d22d2
Compare
68d22d2 to
a32715b
Compare
a238397 to
2df6ad6
Compare
2df6ad6 to
5885f9c
Compare
This is using the Microsoft Sarif.Sdk to write Sarif files.
28af53a to
bf090cf
Compare
refs #554
I've recently been having a go at running some things at work through the FSharp.Analyzers.SDK analysis tools and pushing the generated Sarif report files into DevOps CI builds, and I thought it might be useful to see if I could get FSharpLint results pushed out in the same way - so, this is a first attempt at adding Sarif report generation into FSharpLint.Console.
Note: The Sarif writer code is currently a lightly modified version of the report code from https://github.com/ionide/FSharp.Analyzers.SDK just to try to get it working, so if the code style and such is wrong that's the reason.