Breaking Changes for v1.0 release: drop obsolete APIs and deprecated code/configuration#809
Open
knocte wants to merge 5 commits intofsprojects:masterfrom
Open
Breaking Changes for v1.0 release: drop obsolete APIs and deprecated code/configuration#809knocte wants to merge 5 commits intofsprojects:masterfrom
knocte wants to merge 5 commits intofsprojects:masterfrom
Conversation
To comply with our own naming rules' defaults (which also align better with general .NET API design guidelines). This change was actually inspired by some diff fragments existing in PR467, which was created by original FSharpLint creator @duckmatt as WIP, but which was never finished or merged (yet).
The rule was removed a while ago so we can assume that everyone migrated accordingly (or that anyone that needs to, will, when upgrading to new major version, as this change should land on that version change: -> 1.0).
Co-authored-by: webwarrior-ws <reg@webwarrior.ws>
Being a rule that is related to naming, it was moved recently to the "Naming" subcategory (and folder) inside Conventions; however, all other rules in that folder contained rules that are finding elements depending on the element type (e.g. NestedFunctionNames, PrivateValuesNames, etc), which is not exactly what this rule is doing. So to better differentiate this kind of rule, we change its suffix from "Names" to "Naming".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes in this PR were actually inspired by some diff fragments existing
in PR467 (which was created by original FSharpLint creator @duckmatt
as WIP but which was never finished or merged, yet).