Skip to content

Breaking: Add interpreter_address_val #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zt-chen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Breaking: Add interpreter_address_val #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions fuguex-concrete/src/interpreter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1580,4 +1580,16 @@ impl<O: Order, R: Clone + Default + 'static, const OPERAND_SIZE: usize> Interpre
fn interpreter_space(&self) -> Arc<AddressSpace> {
self.state.memory_space()
}

fn interpreter_address_val(&self, address: Address) -> AddressValue {
// TODO: Check which one is better

// AddressValue from translator
// self.translator.address(address.into())

// AddressValue from memory space
let space = self.state.memory_space();
address.into_address_value(&space)
// AddressValue::new(space, offset)
}
}
3 changes: 2 additions & 1 deletion fuguex-machine/src/traits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use std::sync::Arc;

use fugue::ir::{AddressSpace, IntoAddress};
use fugue::ir::{AddressSpace, IntoAddress, Address, AddressValue};
use fugue::ir::il::Location;
use fugue::ir::il::pcode::{Operand, PCodeOp};
use fugue::ir::space::AddressSpaceId;
Expand Down Expand Up @@ -105,4 +105,5 @@ pub trait Interpreter {
}

fn interpreter_space(&self) -> Arc<AddressSpace>;
fn interpreter_address_val(&self, address: Address) -> AddressValue;
}