Skip to content

Adding a tool to left-align indels#539

Open
nh13 wants to merge 1 commit intomainfrom
nh_left_align_indels
Open

Adding a tool to left-align indels#539
nh13 wants to merge 1 commit intomainfrom
nh_left_align_indels

Conversation

@nh13
Copy link
Member

@nh13 nh13 commented Oct 15, 2019

No description provided.

@nh13 nh13 force-pushed the nh_left_align_indels branch from 298b8d2 to 10d8a2c Compare October 15, 2019 23:30
@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Attention: Patch coverage is 98.55072% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.73%. Comparing base (e780087) to head (fec7b09).

Files with missing lines Patch % Lines
...cala/com/fulcrumgenomics/bam/LeftAlignIndels.scala 98.26% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   95.68%   95.73%   +0.04%     
==========================================
  Files         126      127       +1     
  Lines        7422     7555     +133     
  Branches      494      539      +45     
==========================================
+ Hits         7102     7233     +131     
- Misses        320      322       +2     
Flag Coverage Δ
unittests 95.73% <98.55%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sstadick sstadick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this was excellent for me to read through. The only place where there might be a legitimate change needed and not just a question by me is adding a docstring for the leftAligned value.

@nh13
Copy link
Member Author

nh13 commented Apr 27, 2020

@tfenne can you review this when you get the chance? I'd like to fixup based on @sstadick's comments

@nh13 nh13 unassigned tfenne Mar 5, 2025
@nh13 nh13 force-pushed the nh_left_align_indels branch from 10d8a2c to ed2aac1 Compare March 12, 2025 21:55
@nh13 nh13 force-pushed the nh_left_align_indels branch from ed2aac1 to f1f919c Compare March 12, 2025 21:56
@nh13 nh13 force-pushed the nh_left_align_indels branch from f1f919c to fed8295 Compare March 12, 2025 22:53
@nh13 nh13 temporarily deployed to github-actions March 12, 2025 22:53 — with GitHub Actions Inactive
@nh13 nh13 requested a review from yfarjoun March 12, 2025 22:53
@nh13 nh13 temporarily deployed to github-actions March 12, 2025 22:53 — with GitHub Actions Inactive
}

/** Constructs a Cigar from a padded alignment. */
def cigarFrom(queryPadded: String, targetPadded: String, padChar: Char = '-', softClipChar: Char = 'X', useEqualsAndX: Boolean = false): Cigar = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used in IndelPaddedAlignment but generally useful, so putting it in Alignment

@nh13 nh13 force-pushed the nh_left_align_indels branch from fed8295 to fec7b09 Compare March 12, 2025 22:55
@nh13 nh13 temporarily deployed to github-actions March 12, 2025 22:56 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions March 12, 2025 22:56 — with GitHub Actions Inactive
@nh13 nh13 requested review from clintval and removed request for yfarjoun May 20, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants