Feat/Enable no lags in Forecaster class#214
Open
jhug12 wants to merge 11 commits intofunctime-org:mainfrom
Open
Feat/Enable no lags in Forecaster class#214jhug12 wants to merge 11 commits intofunctime-org:mainfrom
jhug12 wants to merge 11 commits intofunctime-org:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
added Value error to prevent running the backtest without features
Collaborator
|
Ciao @jhug12 and sorry for missing out - I was swamped with work. I will review this hopefully this week. In the meantime: thank you very much for your work. I am merging a couple of other things, so I will ping you later to rebase this branch against main. |
baggiponte
reviewed
May 18, 2024
Author
|
Hi @baggiponte! No worries at all, I totally understand being busy with work. Thanks so much for handling the merging, and just give me a heads-up whenever you need me to rebase the branch. I appreciate your efforts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #205
Summary
This pull request introduces the initial implementation of the
lags=Nonefeature, which currently only functions with thestrategy="recursive"setting. If this approach meets the requirements for solving the referenced issue, I recommend expanding this functionality in a uniform manner throughout the codebase.Proposed Changes
lags=Noneoption in the context ofstrategy="recursive".Code to Test the Implementation