Open
Conversation
… to old solution otherwise.
…dd test for date as well as datetime for fourier terms.
… sorting sets sorted_flag anyway, and 2 set_sorted only works on single column names.
… and remove redundant set_sorted.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Author
|
I just saw #245. This one also fixes it, but ensures that all other tests also pass. |
fabianbergermann
added a commit
to fabianbergermann/functime
that referenced
this pull request
Apr 21, 2025
|
Hi @baggiponte, is this eventually going to be merged? |
Collaborator
Ciao! We are getting back to this with @MathieuCayssol . We need to figure out if we're going to merge this or #259 or this first, but we will get there and credit your contribution. As soon as we can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #255, #253, #250
Makes #251 irrelevant.
Should fix #159
What does this implement/fix? Explain your changes.
This PR fixes all issues with Polars >= 1.0 caught by existing tests.
Has been tested with Polars 1.8.2.
Any other comments?
All issues found were listed in polars' upgrade guide https://docs.pola.rs/releases/upgrade/1/, so versions of polars between 1.0 and 1.8.2 should be fine.