Skip to content

Feature flag to toggle message merging #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesr66a wants to merge 1 commit into
base: meta_response
Choose a base branch
from
Open

Feature flag to toggle message merging #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion fireworks_poe_bot/fw_poe_text_bot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ class TextModelConfig(ModelConfig):

meta_response: Optional[MetaResponse] = None

# Feature flag to disable message merging. TODO: delete the code
merge_messages: bool = True


@register_bot_plugin("text_models", TextModelConfig)
class FireworksPoeTextBot(PoeBot):
Expand All @@ -62,6 +65,7 @@ def __init__(
chat_format: Optional[str],
alpaca_instruction_msg: Optional[str],
meta_response: Optional[MetaResponse],
merge_messages: bool,
completion_async_method: Callable = ChatCompletion.acreate,
):
super().__init__()
Expand All @@ -83,6 +87,7 @@ def __init__(
self.meta_response = MetaResponse(**meta_response)
else:
self.meta_response = meta_response
self.merge_messages = merge_messages

def _log_warn(self, payload: Dict):
payload = copy.copy(payload)
Expand Down Expand Up @@ -290,7 +295,7 @@ async def get_response(
new_messages.append(user_message)
messages = new_messages

if self.chat_format != "alpaca":
if self.chat_format != "alpaca" and self.merge_messages:
# The poe servers send us arbitrary lists of messages. We need to do a few things
# to normalize for our chat completion API:
# 1. Ensure that all assistant messages are preceded by a user message
Expand Down