Skip to content

Comments

add additional launch arg for extraFlag2#2

Merged
murphymatt merged 2 commits intoglm_v4_routingfrom
fix-kernel-launch-config
Nov 10, 2025
Merged

add additional launch arg for extraFlag2#2
murphymatt merged 2 commits intoglm_v4_routingfrom
fix-kernel-launch-config

Conversation

@murphymatt
Copy link

@murphymatt murphymatt commented Nov 6, 2025

📌 Description

We were missing an arg for extraFlag2

🔍 Related Issues

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit (or used your preferred method).
  • I have installed the hooks with pre-commit install.
  • I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

🧪 Tests

  • Tests have been added or updated as needed.
  • All tests are passing (unittest, etc.).

Reviewer Notes

@murphymatt murphymatt requested a review from divchenko November 6, 2025 21:01
Copy link

@divchenko divchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a unit test so we can verify that it's fixed?

@murphymatt murphymatt merged commit d6bbb21 into glm_v4_routing Nov 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants