Merged
Conversation
YLGH
approved these changes
Nov 14, 2025
| enable_pdl: Optional[bool] = None, | ||
| sinks: Optional[List[torch.Tensor]] = None, | ||
| kv_cache_scales: Optional[Tuple[torch.Tensor, torch.Tensor]] = None, | ||
| return_lse: bool = False, |
There was a problem hiding this comment.
Gate return lse just based on if set to None or not?
Author
There was a problem hiding this comment.
they already have this API for ragged_attention, I'm just making it consistent
divchenko
added a commit
that referenced
this pull request
Nov 19, 2025
Add LSE suport in all attention kernels
divchenko
added a commit
that referenced
this pull request
Dec 6, 2025
Add LSE suport in all attention kernels
murphymatt
pushed a commit
that referenced
this pull request
Dec 15, 2025
Add LSE suport in all attention kernels
divchenko
added a commit
that referenced
this pull request
Dec 17, 2025
Add LSE suport in all attention kernels
divchenko
added a commit
that referenced
this pull request
Dec 18, 2025
Add LSE suport in all attention kernels
murphymatt
pushed a commit
that referenced
this pull request
Jan 14, 2026
Add LSE suport in all attention kernels
murphymatt
pushed a commit
that referenced
this pull request
Jan 16, 2026
Add LSE suport in all attention kernels
murphymatt
pushed a commit
that referenced
this pull request
Jan 26, 2026
Add LSE suport in all attention kernels
murphymatt
pushed a commit
that referenced
this pull request
Jan 26, 2026
Add LSE suport in all attention kernels
murphymatt
pushed a commit
that referenced
this pull request
Jan 26, 2026
Add LSE suport in all attention kernels
murphymatt
pushed a commit
that referenced
this pull request
Jan 26, 2026
Add LSE suport in all attention kernels
murphymatt
pushed a commit
that referenced
this pull request
Jan 27, 2026
Add LSE suport in all attention kernels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add LSE suport in all attention kernels.
Allow strides for retuned LSEs.