Open
Conversation
fwcd
reviewed
Aug 25, 2022
| /** Subtracts two 2D vectors. */ | ||
| export function sub(lhs: PartialVec2, rhs: PartialVec2): Vec2 { | ||
| return { x: (lhs.x ?? 0) - (rhs.x ?? 0), y: (lhs.y ?? 0) - (rhs.y ?? 0) }; | ||
| return add(lhs, scale(rhs, -1)); |
Owner
There was a problem hiding this comment.
Yeah we could do this, my idea was that subtraction is so fundamental that it ought to be as fast as possible, so I'd actually lean towards keeping it as is (though perhaps we'd want to default the parameters to { x = 0, y = 0 } to make it less verbose).
| /** Scales a 2D vector. */ | ||
| export function scale(lhs: PartialVec2, rhs: number): Vec2 { | ||
| return { x: (lhs.x ?? 0) * rhs, y: (lhs.y ?? 0) * rhs }; | ||
| export function scale({ x = 0, y = 0 }: PartialVec2, rhs: number): Vec2 { |
Owner
There was a problem hiding this comment.
If we default these parameters, the vector no longer needs to be a PartialVec2, right?
Suggested change
| export function scale({ x = 0, y = 0 }: PartialVec2, rhs: number): Vec2 { | |
| export function scale({ x = 0, y = 0 }: Vec2, rhs: number): Vec2 { |
Also it would be great if we could use this trick for add and sub too, for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to refactor some parts of the example code.
E.g., it introduces the usage of the
Partial<T>type, takes usage of restructuring and reduces code duplication.