feat: add tcpDebug option and tracing#618
Conversation
github-actions
bot
added
the
build
|
@fwcd this is for the log feature |
Decodetalkers
force-pushed
the
logfeature
branch
from
53b2527 to
2ea49b1
Compare
server/build.gradle.kts
Outdated
| standardInput = System.`in` | ||
|
|
||
| jvmArgs(debugArgs) | ||
| args(listOf("--tcpServerPort", serverDebugPort, "--tcpDebug", "--tracingLog")) |
There was a problem hiding this comment.
Hm this changes the default from stdio, right? Does
./gradlew debugRun --args '--tcpServerPort ... --tcpDebug --tracingLog'
work? If so, I wouldn't change this.
There was a problem hiding this comment.
Seems not work.. Maybe I do not really know how to make gradle work.. I also try to use --args to pass argument to task.. but it never works
| override fun getNotebookDocumentService(): NotebookDocumentService? { | ||
| return null; | ||
| } | ||
| return null; |
There was a problem hiding this comment.
Same here (though if we reformat this, we could remove the redundant semicolon and write the function as = null directly)
| @Parameter(names = ["--tracingLog"]) | ||
| var tracingLog: Boolean = false |
There was a problem hiding this comment.
I'd probably prefer making this a more general option for passing the log level if that's an option
There was a problem hiding this comment.
I see, I will make this part to pass string, and if is tracing, I will tracing the function class name
Decodetalkers
force-pushed
the
logfeature
branch
2 times, most recently
from
b5a976a to
9035968
Compare
Decodetalkers
force-pushed
the
logfeature
branch
from
9035968 to
dc24041
Compare
|
Sorry.. seems after rebase.. the commit disappear.. |
Decodetalkers
force-pushed
the
logfeature
branch
from
9d89ac9 to
2387d91
Compare
|
May you review again? @fwcd I hope this repo will be still active |
Decodetalkers
force-pushed
the
logfeature
branch
from
2387d91 to
364d0f3
Compare
3 participants
this made me easier to debug the project
and fix some warning