Skip to content

fix: silence SSO browser stdout #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TGNThump wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: silence SSO browser stdout #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/testing/browser/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
package main

import (
"fmt"
"os"
)

// This package is used to test browser features in tests
func main() {
// Make sure we can handle a browser printing something stdout (like Chrome does)
fmt.Println("Opening in existing browser session.")
os.Exit(0)
}
5 changes: 5 additions & 0 deletions pkg/idclogin/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"errors"
"fmt"
"os"
"os/exec"
"time"

Expand Down Expand Up @@ -95,6 +96,8 @@ func Login(ctx context.Context, cfg aws.Config, startUrl string, scopes []string
} else {
clio.Debugf("running command without forkprocess: %s", args)
cmd := exec.Command(args[0], args[1:]...)
cmd.Stdout = os.Stderr
cmd.Stderr = os.Stderr
startErr = cmd.Start()
}

Expand All @@ -108,6 +111,8 @@ func Login(ctx context.Context, cfg aws.Config, startUrl string, scopes []string

} else if config.CustomSSOBrowserPath != "" {
cmd := exec.Command(config.CustomSSOBrowserPath, url)
cmd.Stdout = os.Stderr
cmd.Stderr = os.Stderr
err = cmd.Start()
if err != nil {
// fail silently
Expand Down