Skip to content

Comments

chore: support build adapters for editor-decorators#2623

Merged
MrKou47 merged 1 commit intomainfrom
chore/add-action
Apr 17, 2025
Merged

chore: support build adapters for editor-decorators#2623
MrKou47 merged 1 commit intomainfrom
chore/add-action

Conversation

@MrKou47
Copy link
Member

@MrKou47 MrKou47 commented Apr 16, 2025

Summary by CodeRabbit

  • Chores
    • Integrated the editor decorators package into the release build and packaging process. The editor decorators' browser bundle is now included in the platform adapter bundle.

@coderabbitai
Copy link

coderabbitai bot commented Apr 16, 2025

Walkthrough

This change updates the release workflow configuration to integrate the galacean/editor repository into the build process. The workflow now checks out the editor repository, installs its dependencies, and builds the decorators package. The resulting build artifacts are then copied into the packaging directory and included in the platform adapter bundle alongside other JavaScript files. No changes to exported or public entities were made.

Changes

File(s) Change Summary
.github/workflows/release.yml Updated workflow to checkout galacean/editor, build the decorators package, and include its output in the packaging and bundling steps.

Sequence Diagram(s)

sequenceDiagram
    participant Workflow
    participant EditorRepo
    participant PackagingDir

    Workflow->>EditorRepo: Checkout galacean/editor repository
    Workflow->>EditorRepo: Install dependencies
    Workflow->>EditorRepo: Build decorators package
    EditorRepo->>PackagingDir: Copy built decorators to temp/@galacean/editor-decorators
    Workflow->>PackagingDir: Include decorators bundle in platform adapter package
Loading

Possibly related PRs

  • feat: update release action #2474: Both PRs modify the .github/workflows/release.yml file to enhance the release process by adding steps for checking out and building additional repositories or packages, integrating them into the release workflow.

Suggested labels

ignore for release

Suggested reviewers

  • GuoLei1990

Poem

A bunny hops through YAML fields,
Gathering decorators for shiny yields.
With every build and checkout done,
The editor’s magic is now spun.
Bundles packed and ready to go—
Release day’s here, let’s start the show!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf5d6f9 and 0c45c55.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: e2e (22.x)
  • GitHub Check: build (22.x, windows-latest)
🔇 Additional comments (4)
.github/workflows/release.yml (4)

51-57: Editor repository checkout is correct and secure.

The use of a secret token and a dedicated path for the editor repository is appropriate.


58-63: Editor decorators build step is well-integrated.

The workflow correctly installs dependencies and builds the decorators package. Ensure that the build:decorators script is always present in the editor repository to avoid CI failures.

Would you like a script to verify the presence of the build:decorators script in the editor repo's package.json?


108-109: Editor decorators artifacts are correctly staged for packaging.

The temp directory structure and copy command are consistent with other packages.


141-141: Editor decorators are correctly included in the adapter bundle.

This ensures the decorators are part of the final platform adapter output.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.47%. Comparing base (05dd841) to head (0c45c55).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2623      +/-   ##
==========================================
+ Coverage   68.96%   69.47%   +0.50%     
==========================================
  Files         961      961              
  Lines      100345   100406      +61     
  Branches     8672     8699      +27     
==========================================
+ Hits        69203    69755     +552     
+ Misses      30882    30391     -491     
  Partials      260      260              
Flag Coverage Δ
unittests 69.47% <ø> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MrKou47 MrKou47 merged commit ab2008f into main Apr 17, 2025
9 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Apr 28, 2025
3 tasks
@GuoLei1990 GuoLei1990 deleted the chore/add-action branch May 20, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant