Fix masklayer return type in SpriteRenderer and TextRenderer

[singlecoder]

Summary by CodeRabbit

• Refactor
  • Improved type safety for the mask layer property in 2D sprite and text rendering components by using a more specific type. No changes to functionality.

[coderabbitai]

Walkthrough

The changes update the type annotations for the maskLayer property in both the SpriteRenderer and TextRenderer classes. The getter and setter for maskLayer now use the SpriteMaskLayer enum type instead of a generic number type. Additionally, the SpriteMaskLayer enum is imported where necessary. No changes to implementation logic or control flow are present; only type signatures are affected.

Changes

File(s)	Change Summary
packages/core/src/2d/sprite/SpriteRenderer.ts	Updated maskLayer getter and setter to use SpriteMaskLayer enum type instead of number.
packages/core/src/2d/text/TextRenderer.ts	Imported SpriteMaskLayer and updated maskLayer getter and setter to use the enum type.

Poem

A hop and a skip, a type change appears,
From numbers to enums, the intent now clears.
Mask layers defined, with types oh so bright,
Sprite and Text renderers hopping in delight.
With every enum, our code feels more right!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf5d6f9 and 89ba15f.

📒 Files selected for processing (2)

• packages/core/src/2d/sprite/SpriteRenderer.ts (2 hunks)
• packages/core/src/2d/text/TextRenderer.ts (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

packages/core/src/2d/sprite/SpriteRenderer.ts (1)

packages/core/src/index.ts (1)

• SpriteMaskLayer (48-48)

🔇 Additional comments (6)

packages/core/src/2d/sprite/SpriteRenderer.ts (3)

21-21: Good addition of SpriteMaskLayer import.

The import statement for the SpriteMaskLayer enum is properly added to support the type changes for the maskLayer property.

---

244-246: Improved type safety with SpriteMaskLayer enum.

Changing the return type from number to the more specific SpriteMaskLayer enum improves type safety and provides better code completion support.

---

248-250: Consistent enum usage in setter method.

The parameter type change from number to SpriteMaskLayer ensures consistency between getter and setter, which is a good practice for TypeScript property implementations.

packages/core/src/2d/text/TextRenderer.ts (3)

24-24: Good addition of SpriteMaskLayer import.

The import statement for the SpriteMaskLayer enum is properly added to support the type changes for the maskLayer property.

---

258-260: Improved type safety with SpriteMaskLayer enum.

Changing the return type from number to the more specific SpriteMaskLayer enum improves type safety and provides better code completion support.

---

262-264: Consistent enum usage in setter method.

The parameter type change from number to SpriteMaskLayer ensures consistency between getter and setter, which is a good practice for TypeScript property implementations.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.48%. Comparing base (cf5d6f9) to head (89ba15f).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2625      +/-   ##
==========================================
+ Coverage   69.01%   69.48%   +0.46%     
==========================================
  Files         961      961              
  Lines      100406   100408       +2     
  Branches     8699     8700       +1     
==========================================
+ Hits        69300    69773     +473     
+ Misses      30846    30375     -471     
  Partials      260      260              

Flag	Coverage Δ
unittests	69.48% <100.00%> (+0.46%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.